From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [RFC][PATCH] tracking dirty pages in shared mappings From: Peter Zijlstra In-Reply-To: References: <1146861313.3561.13.camel@lappy> <445CA22B.8030807@cyberone.com.au> <1146922446.3561.20.camel@lappy> <445CA907.9060002@cyberone.com.au> <1146929357.3561.28.camel@lappy> Content-Type: text/plain Date: Mon, 08 May 2006 09:23:03 +0200 Message-Id: <1147072984.24053.4.camel@lappy> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Nick Piggin , Linus Torvalds , Andi Kleen , Rohit Seth , Andrew Morton , mbligh@google.com, hugh@veritas.com, riel@redhat.com, andrea@suse.de, arjan@infradead.org, apw@shadowen.org, mel@csn.ul.ie, marcelo@kvack.org, anton@samba.org, paulmck@us.ibm.com, linux-mm List-ID: On Sun, 2006-05-07 at 23:43 -0700, Christoph Lameter wrote: > On Sat, 6 May 2006, Peter Zijlstra wrote: > > > Attached are both a new version of the shared_mapping_dirty patch, and > > balance_dirty_pages; to be applied in that order. > > Would you please sent patches inline? Ofcourse, will do next round; in the meantime you can get the patches from: http://programming.kicks-ass.net/kernel-patches/shared-dirty/ > It seems that you need to initialize > mapping to NULL in handle_pte_fault. Almost, the dirty count avoids that. I should just init mapping to NULL and drop the dirty count; there is no way that can ever be more than 1 anyway. > You could defer the page dirtying by taking a reference on the page then > dropping the pte lock dirty the page and then drop the reference. That way > dirtying is running without the pte lock. Right, very good, will do that when I get home. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org