Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

Rik van Riel
2006-08-12T14:40:23Z

Evgeniy Polyakov wrote:
> On Sat, Aug 12, 2006 at 11:19:49AM +0200, Peter Zijlstra (a.p.zijlstra@chello.nl) wrote:
>>> As you described above, memory for each packet must be allocated (either
>>> from SLAB or from reserve), so network needs special allocator in OOM
>>> condition, and that allocator should be separated from SLAB's one which
>>> got OOM, so my purpose is just to use that different allocator (with
>>> additional features) for netroking always.
>
> No it is not. There are socket queues and they are limited. Things like
> TCP behave even better.

Ahhh, but there are two allocators in play here.

The first one allocates the memory for receiving packets.
This can be one pool, as long as it is isolated from
other things in the system it is fine.

The second allocator allocates more memory for socket
buffers. The memory critical sockets should get their
memory from a mempool, once normal socket memory
allocations start failing.

This means our allocation differentiation only needs
to happen at the socket stage.

Or am I overlooking something?

--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan