Re: [RFC][PATCH 3/9] e1000 driver conversion

Auke Kok
2006-08-08T20:50:33Z

Peter Zijlstra wrote:
> Update the driver to make use of the NETIF_F_MEMALLOC feature.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: Daniel Phillips <phillips@google.com>
>
> ---
> drivers/net/e1000/e1000_main.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> Index: linux-2.6/drivers/net/e1000/e1000_main.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/e1000/e1000_main.c
> +++ linux-2.6/drivers/net/e1000/e1000_main.c
> @@ -4020,8 +4020,6 @@ e1000_alloc_rx_buffers(struct e1000_adap
> */
> skb_reserve(skb, NET_IP_ALIGN);
>
> - skb->dev = netdev;
> -
> buffer_info->skb = skb;
> buffer_info->length = adapter->rx_buffer_len;
> map_skb:
> @@ -4135,8 +4136,6 @@ e1000_alloc_rx_buffers_ps(struct e1000_a
> */
> skb_reserve(skb, NET_IP_ALIGN);
>
> - skb->dev = netdev;
> -
> buffer_info->skb = skb;
> buffer_info->length = adapter->rx_ps_bsize0;
> buffer_info->dma = pci_map_single(pdev, skb->data,
> -

can we really delete these??

Cheers,

Auke