From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] Split the free lists into kernel and user parts
Date: Fri, 08 Sep 2006 09:54:00 +0200 [thread overview]
Message-ID: <1157702040.17799.40.camel@lappy> (raw)
In-Reply-To: <20060907190422.6166.49758.sendpatchset@skynet.skynet.ie>
Hi Mel,
Looking good, some small nits follow.
On Thu, 2006-09-07 at 20:04 +0100, Mel Gorman wrote:
> +#define for_each_rclmtype_order(type, order) \
> + for (order = 0; order < MAX_ORDER; order++) \
> + for (type = 0; type < RCLM_TYPES; type++)
It seems odd to me that you have the for loops in reverse order of the
arguments.
> +static inline int get_pageblock_type(struct page *page)
> +{
> + return (PageEasyRclm(page) != 0);
> +}
I find the naming a little odd, I would have suspected something like:
get_page_blocktype() or thereabout since you're getting a page
attribute.
> +static inline int gfpflags_to_rclmtype(unsigned long gfp_flags)
> +{
> + return ((gfp_flags & __GFP_EASYRCLM) != 0);
> +}
gfp_t argument?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-09-08 7:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-07 19:03 [PATCH 0/8] Avoiding fragmentation with subzone groupings v25 Mel Gorman
2006-09-07 19:04 ` [PATCH 1/8] Add __GFP_EASYRCLM flag and update callers Mel Gorman
2006-09-07 19:04 ` [PATCH 2/8] Split the free lists into kernel and user parts Mel Gorman
2006-09-08 7:54 ` Peter Zijlstra [this message]
2006-09-08 9:20 ` Mel Gorman
2006-09-07 19:04 ` [PATCH 3/8] Split the per-cpu " Mel Gorman
2006-09-07 19:05 ` [PATCH 4/8] Add a configure option for anti-fragmentation Mel Gorman
2006-09-07 19:05 ` [PATCH 5/8] Drain per-cpu lists when high-order allocations fail Mel Gorman
2006-09-07 19:05 ` [PATCH 6/8] Move free pages between lists on steal Mel Gorman
2006-09-07 19:06 ` [PATCH 7/8] Introduce the RCLM_KERN allocation type Mel Gorman
2006-09-07 19:06 ` [PATCH 8/8] [DEBUG] Add statistics Mel Gorman
2006-09-08 0:58 ` [PATCH 0/8] Avoiding fragmentation with subzone groupings v25 Andrew Morton
2006-09-08 8:30 ` Peter Zijlstra
2006-09-08 9:24 ` Mel Gorman
2006-09-08 8:36 ` Mel Gorman
2006-09-08 13:06 ` Peter Zijlstra
2006-09-08 13:16 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157702040.17799.40.camel@lappy \
--to=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).