From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] nfs: fix congestion control From: Peter Zijlstra In-Reply-To: <1169070886.6523.8.camel@lade.trondhjem.org> References: <20070116054743.15358.77287.sendpatchset@schroedinger.engr.sgi.com> <20070116135325.3441f62b.akpm@osdl.org> <1168985323.5975.53.camel@lappy> <1169070763.5975.70.camel@lappy> <1169070886.6523.8.camel@lade.trondhjem.org> Content-Type: text/plain Date: Thu, 18 Jan 2007 14:27:48 +0100 Message-Id: <1169126868.6197.55.camel@twins> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Trond Myklebust Cc: Christoph Lameter , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Wed, 2007-01-17 at 16:54 -0500, Trond Myklebust wrote: > On Wed, 2007-01-17 at 22:52 +0100, Peter Zijlstra wrote: > > > > > > > > Index: linux-2.6-git/fs/inode.c > > > > =================================================================== > > > > --- linux-2.6-git.orig/fs/inode.c 2007-01-12 08:03:47.000000000 +0100 > > > > +++ linux-2.6-git/fs/inode.c 2007-01-12 08:53:26.000000000 +0100 > > > > @@ -81,6 +81,7 @@ static struct hlist_head *inode_hashtabl > > > > * the i_state of an inode while it is in use.. > > > > */ > > > > DEFINE_SPINLOCK(inode_lock); > > > > +EXPORT_SYMBOL_GPL(inode_lock); > > > > > > Hmmm... Commits to all NFS servers will be globally serialized via the > > > inode_lock? > > > > Hmm, right, thats not good indeed, I can pull the call to > > nfs_commit_list() out of that loop. > > There is no reason to modify any of the commit stuff. Please just drop > that code. I though you agreed to flushing commit pages when hitting the dirty page limit. Or would you rather see a notifier chain from congestion_wait() calling into the various NFS mounts? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org