From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: [KJ][PATCH] is_power_of_2 in ia64mm From: Vignesh Babu BM Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Fri, 16 Feb 2007 17:33:55 +0530 Message-Id: <1171627435.6127.0.camel@wriver-t81fb058.linuxcoe> Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org Return-Path: To: Kernel Janitors List Cc: tony.luck@intel.com, linux-ia64@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 diff --git a/arch/ia64/mm/hugetlbpage.c b/arch/ia64/mm/hugetlbpage.c index 0c7e94e..0ccc70e 100644 --- a/arch/ia64/mm/hugetlbpage.c +++ b/arch/ia64/mm/hugetlbpage.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -175,7 +176,7 @@ static int __init hugetlb_setup_sz(char *str) tr_pages = 0x15557000UL; size = memparse(str, &str); - if (*str || (size & (size-1)) || !(tr_pages & size) || + if (*str || !is_power_of_2(size) || !(tr_pages & size) || size <= PAGE_SIZE || size >= (1UL << PAGE_SHIFT << MAX_ORDER)) { printk(KERN_WARNING "Invalid huge page size specified\n"); -- Regards, Vignesh Babu BM _____________________________________________________________ "Why is it that every time I'm with you, makes me believe in magic?" -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org