Re: [PATCH 12/14] get_unmapped_area handles MAP_FIXED in /dev/mem (nommu)

Benjamin Herrenschmidt
2007-04-04T23:14:12Z

On Wed, 2007-04-04 at 11:31 +0100, David Howells wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > + if (flags & MAP_FIXED)
> > + if ((addr >> PAGE_SHIFT) != pgoff)
> > + return (unsigned long) -EINVAL;
>
> Again... in NOMMU-mode there is no MAP_FIXED - it's rejected before we get
> this far.
>
> > - return pgoff;
> > + return pgoff << PAGE_SHIFT;
>
> That, however, does appear to be a genuine bugfix.

I'll separate it from the rest of the patches

Ben.