Re: [patch 3/8] mm: merge nopfn into fault

Benjamin Herrenschmidt
2007-05-24T03:48:18Z

On Wed, 2007-05-23 at 20:37 -0700, Linus Torvalds wrote:
>
> So just about any "hiding" would do it as far as I'm concerned. Ranging
> from the odd (making it a "virtual page number") to just using an
> inconvenient name that just makes it obvious that it shouldn't be used
> lightly ("virtual_page_fault_address"), to making it a type that cannot
> easily be used for that kind of arithmetic ("void __user *" would make
> sense, no?).

Yes, I like void __user *. I don't like long names because they make the
struct definition ugly though. What about

void __user *_fault_target; /* for internal use only */

Is that scary enough ? :-)

Cheers,
Ben.