Re: [patch 3/8] mm: merge nopfn into fault

Benjamin Herrenschmidt
2007-05-24T03:26:24Z

On Thu, 2007-05-24 at 13:17 +1000, Benjamin Herrenschmidt wrote:
> Fair but in the case of spufs, I -do- have to much with the address in
> the driver/fs since it's the driver that knows it wants to use 64K
> page
> mappings, and thus need to insert the PTE with the special 64K flag in
> the first of the 16 entries of that 64K region -and- align the address
> down before passing it to vm_insert_pfn().

Note that I culd just modify the address/page index in the struct
vm_fault... doesn't make much difference in this case.

Might even create an arch helper prepare_special_pgsize_fault() or
something like that that takes the VM fault struct, whack it the right
way, and returns it to the driver for passing to vm_insert_pfn() so that
all of the logic is actually hidden from the driver.

Ben.