Re: [-mm PATCH 4/8] Memory controller memory accounting (v2)

YAMAMOTO Takashi
2007-07-10T08:44:27Z

> On 7/10/07, YAMAMOTO Takashi <yamamoto@valinux.co.jp> wrote:
> > hi,
> >
> > > diff -puN mm/memory.c~mem-control-accounting mm/memory.c
> > > --- linux-2.6.22-rc6/mm/memory.c~mem-control-accounting 2007-07-05 13:45:18.000000000 -0700
> > > +++ linux-2.6.22-rc6-balbir/mm/memory.c 2007-07-05 13:45:18.000000000 -0700
> >
> > > @@ -1731,6 +1736,9 @@ gotten:
> > > cow_user_page(new_page, old_page, address, vma);
> > > }
> > >
> > > + if (mem_container_charge(new_page, mm))
> > > + goto oom;
> > > +
> > > /*
> > > * Re-check the pte - we dropped the lock
> > > */
> >
> > it seems that the page will be leaked on error.
>
> You mean meta_page right?

no. i meant 'new_page'.

YAMAMOTO Takashi