Re: [PATCH/RFC] Memoryless nodes: Suppress redundant "node with no memory" messages

Nishanth Aravamudan
2007-07-25T15:56:26Z

On 24.07.2007 [16:35:13 -0400], Lee Schermerhorn wrote:
> Suppress redundant "node with no memory" messages
>
> Against 2.6.22-rc6-mm1 atop Christoph Lameter's memoryless
> node series.
>
> get_pfn_range_for_nid() is called multiple times for each node
> at boot time. Each time, it will warn about nodes with no
> memory, resulting in boot messages like:
>
> Node 0 active with no memory
> Node 0 active with no memory
> Node 0 active with no memory
> Node 0 active with no memory
> Node 0 active with no memory
> Node 0 active with no memory
> On node 0 totalpages: 0
> Node 0 active with no memory
> Node 0 active with no memory
> DMA zone: 0 pages used for memmap
> Node 0 active with no memory
> Node 0 active with no memory
> Normal zone: 0 pages used for memmap
> Node 0 active with no memory
> Node 0 active with no memory
> Movable zone: 0 pages used for memmap
>
> and so on for each memoryless node. Track [in init data]
> memoryless nodes that we've already reported to suppress
> the redundant messages.
>
> OR, we could eliminate the message altogether? We do
> report zero totalpages. Sufficient?

Not being an expert, I honestly don't know. But I do think it's quite
clear that we only need one or the other type of message (presuming both
are always shown, that is neither can somehow already be disabled), as
they say the same thing :) I found this to be odd behavior too.

> Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
Acked-by: Nishanth Aravamudan <nacc@us.ibm.com>

--
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center