From: Pankaj Gupta <pagupta@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Konstantin Khlebnikov <koct9i@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
linux-mm@kvack.org
Subject: Re: [PATCH v1] mm: balloon: drop unused function stubs
Date: Mon, 1 Apr 2019 02:05:02 -0400 (EDT) [thread overview]
Message-ID: <1185594000.16522589.1554098702713.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190329122649.28404-1-david@redhat.com>
>
> These are leftovers from the pre-"general non-lru movable page" era.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> include/linux/balloon_compaction.h | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/include/linux/balloon_compaction.h
> b/include/linux/balloon_compaction.h
> index f111c780ef1d..f31521dcb09a 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page
> *page)
> list_del(&page->lru);
> }
>
> -static inline bool __is_movable_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool balloon_page_movable(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool isolated_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> static inline bool balloon_page_isolate(struct page *page)
> {
> return false;
> --
> 2.17.2
Looks good to me.
Acked-by: Pankaj Gupta <pagupta@redhat.com>
>
>
next prev parent reply other threads:[~2019-04-01 6:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 12:26 [PATCH v1] mm: balloon: drop unused function stubs David Hildenbrand
2019-03-29 13:55 ` Mukesh Ojha
2019-03-29 14:12 ` Michael S. Tsirkin
2019-04-01 6:05 ` Pankaj Gupta [this message]
2019-04-02 18:23 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185594000.16522589.1554098702713.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).