Re: [PATCH] Add "removable" to /sysfs to show memblock removability

[Dave Hansen <haveblue@us.ibm.com>]

On Thu, 2007-10-25 at 15:35 -0700, Badari Pulavarty wrote:
> 
> +static ssize_t show_mem_removable(struct sys_device *dev, char *buf)
> +{
> +       unsigned long start_pfn;
> +       struct memory_block *mem =
> +               container_of(dev, struct memory_block, sysdev);
> +
> +       start_pfn = section_nr_to_pfn(mem->phys_index);
> +       if (is_mem_section_removable(start_pfn, PAGES_PER_SECTION))
> +               return sprintf(buf, "True\n");
> +       else
> +               return sprintf(buf, "False\n");
> + 

Yeah, that's what I had in mind.  The only other thing I might suggest
would be to do a number instead of true/false here.  Just so that we
_can_ have scores in the future.  Otherwise fine with me.

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>