From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id l9Q8Mpkp151960 for ; Fri, 26 Oct 2007 08:22:51 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9Q8MptN2109636 for ; Fri, 26 Oct 2007 10:22:51 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9Q8Mo23022759 for ; Fri, 26 Oct 2007 10:22:51 +0200 Subject: Re: [patch 3/6] arch_update_pgd call From: Martin Schwidefsky Reply-To: schwidefsky@de.ibm.com In-Reply-To: <1193385543.13638.0.camel@pasglop> References: <20071025181520.880272069@de.ibm.com> <20071025181901.591007141@de.ibm.com> <1193345285.7018.21.camel@pasglop> <1193384437.31831.3.camel@localhost> <1193385543.13638.0.camel@pasglop> Content-Type: text/plain Date: Fri, 26 Oct 2007 10:22:50 +0200 Message-Id: <1193386970.31831.20.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: benh@kernel.crashing.org Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, borntraeger@de.ibm.com List-ID: On Fri, 2007-10-26 at 17:59 +1000, Benjamin Herrenschmidt wrote: > > > I'm not at all fan of the hook there and it's name... > > > > > > Any reason why you can't do that in your arch gua ? > > > > > > If not, then why can't you call it something nicer, like > > > arch_rebalance_pgtables() ? > > > > The name can be changed in no time. I've tried to use one of the > > existing arch calls like arch_mmap_check or arch_get_unmapped_area but > > it didn't work out. I really need the final address to make the call to > > extend the page tables. > > You arch get_unmapped_area() has it... Hmm, I got worried about the file->f_op->get_unmapped_area indirection. At least the get_unmapped_area_mem function in drivers/char/mem.c does not call the standard get_unmapped_area function again like ipc/shm.c does. As I see it is not guaranteed that the architecture version of arch_get_unmapped_area gets control. Want to play safe there. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org