Re: [PATCH] memory cgroup enhancements [0/5] intro

Balbir Singh
2007-10-16T18:21:10Z

KAMEZAWA Hiroyuki wrote:
> This patch set adds
> - force_empty interface, which drops all charges in memory cgroup.
> This enables rmdir() against unused memory cgroup.
> - the memory cgroup statistics accounting.
>
> Based on 2.6.23-mm1 + http://lkml.org/lkml/2007/10/12/53
>
> Changes from previous version is
> - merged comments.
> - based on 2.6.23-mm1
> - removed Charge/Uncharge counter.
>
> [1/5] ... force_empty patch
> [2/5] ... remember page is charged as page-cache patch
> [3/5] ... remember page is on which list patch
> [4/5] ... memory cgroup statistics patch
> [5/5] ... show statistics patch
>
> tested on x86-64/fake-NUMA + CONFIG_PREEMPT=y/n (for testing preempt_disable())
>
> Any comments are welcome.
>

Hi, KAMEZAWA-San,

I would prefer these patches to go in once the fixes that you've posted
earlier have gone in (the migration fix series). I am yet to test the
migration fix per-se, but the series seemed quite fine to me. Andrew
could you please pick it up.

> -Kame
>

--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL