Re: [PATCH] memory cgroup enhancements [3/5] record pc is on active list

KAMEZAWA Hiroyuki
2007-10-17T05:16:29Z

On Tue, 16 Oct 2007 21:17:24 -0700 (PDT)
David Rientjes <rientjes@google.com> wrote:

> On Tue, 16 Oct 2007, KAMEZAWA Hiroyuki wrote:
>
> > Remember page_cgroup is on active_list or not in page_cgroup->flags.
> >
> > Against 2.6.23-mm1.
> >
> > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > Signed-off-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
> >
> > mm/memcontrol.c | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > Index: devel-2.6.23-mm1/mm/memcontrol.c
> > ===================================================================
> > --- devel-2.6.23-mm1.orig/mm/memcontrol.c
> > +++ devel-2.6.23-mm1/mm/memcontrol.c
> > @@ -85,6 +85,7 @@ struct page_cgroup {
> > /* mapped and cached states */
> > int flags;
> > #define PCGF_PAGECACHE (0x1) /* charged as page-cache */
> > +#define PCGF_ACTIVE (0x2) /* this is on cgroup's active list */
>
> Please move these flag #defines out of the struct definition.
>
ok

-Kame