From: aglitke <agl@us.ibm.com>
To: Ken Chen <kenchen@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [patch] hugetlb: fix i_blocks accounting
Date: Mon, 12 Nov 2007 08:53:44 -0600 [thread overview]
Message-ID: <1194879224.14675.61.camel@localhost.localdomain> (raw)
In-Reply-To: <b040c32a0711091734s13d4ffcaj4123dd27d24bf330@mail.gmail.com>
On Fri, 2007-11-09 at 17:34 -0800, Ken Chen wrote:
> On Nov 9, 2007 5:16 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> > On Fri, 09 Nov 2007 12:09:57 -0600
> > aglitke <agl@us.ibm.com> wrote:
> >
> > > Thanks for that explanation. It makes complete sense to me now.
> >
> > We have a distressing number of hugetlb patches here:
> >
> > hugetlb-follow_hugetlb_page-for-write-access.patch
> > hugetlb-allow-sticky-directory-mount-option.patch
> > hugetlb-split-alloc_huge_page-into-private-and-shared-components.patch
> > hugetlb-split-alloc_huge_page-into-private-and-shared-components-checkpatch-fixes.patch
> > hugetlb-fix-quota-management-for-private-mappings.patch
> > hugetlb-debit-quota-in-alloc_huge_page.patch
> > hugetlb-allow-bulk-updating-in-hugetlb__quota.patch
> > hugetlb-enforce-quotas-during-reservation-for-shared-mappings.patch
> > mm-hugetlbc-make-a-function-static.patch
> > hugetlb-fix-i_blocks-accounting.patch
> >
> > (all available at http://userweb.kernel.org/~akpm/mmotm/)
> >
> > Could we please put heads together and work out which of these need to go
> > into 2.6.24? And 2.6.23, come to that...
>
> I would vote all of it. If we really need to prioritize them, I would
> list them in the following order:
I agree that all of them are ready to go for 2.6.24. I don't think #3
(follow_hugetlb_page fix) meets the criteria for a -stable patch
otherwise I'd have suggested it go forth into 2.6.23.
> 1. fs quota fix:
> hugetlb-split-alloc_huge_page-into-private-and-shared-components.patch
> hugetlb-split-alloc_huge_page-into-private-and-shared-components-checkpatch-fixes.patch
> hugetlb-fix-quota-management-for-private-mappings.patch
> hugetlb-debit-quota-in-alloc_huge_page.patch
> hugetlb-allow-bulk-updating-in-hugetlb__quota.patch
> hugetlb-enforce-quotas-during-reservation-for-shared-mappings.patch
>
> 2. i_blocks accounting
> hugetlb-fix-i_blocks-accounting.patch
>
> 3. follow_hugetlb_page (this is a rather nasty bug, I'm glad we
> haven't hit it in real world. Or maybe Adam did, and hence the
> patch?).
We're starting to see this with the infiniband driver. They have a
workaround (to touch each hugepage in userspace before handing it to the
driver), but the sooner it gets fixed upstream, the better obviously.
> hugetlb-follow_hugetlb_page-for-write-access.patch
>
> 4. others (these are really simple single line low risk patches, why not?)
> hugetlb-allow-sticky-directory-mount-option.patch
> mm-hugetlbc-make-a-function-static.patch
>
> oh, there are more bugs in hugetlb: sys_mincore isn't working on
> hugetlb range. I guess that can wait for 2.6.25.
>
--
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-11-12 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b040c32a0711082343t2b94b495r1608d99ec0e28a4c@mail.gmail.com>
2007-11-09 17:31 ` [patch] hugetlb: fix i_blocks accounting Ken Chen
[not found] ` <1194617837.14675.45.camel@localhost.localdomain>
2007-11-09 17:42 ` Ken Chen
2007-11-09 18:09 ` aglitke
2007-11-10 1:16 ` Andrew Morton
2007-11-10 1:34 ` Ken Chen
2007-11-12 14:53 ` aglitke [this message]
2007-10-20 18:18 Ken Chen
2007-10-23 14:52 ` Adam Litke
2007-10-24 0:34 ` Ken Chen
2007-10-24 13:06 ` Adam Litke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194879224.14675.61.camel@localhost.localdomain \
--to=agl@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kenchen@google.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).