From: Dave Hansen <haveblue@us.ibm.com>
To: Nishanth Aravamudan <nacc@us.ibm.com>
Cc: akpm@linux-foundation.org, mel@skynet.ie, wli@holomorphy.com,
apw@shadowen.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: fix confusing __GFP_REPEAT related comments
Date: Thu, 29 Nov 2007 15:14:40 -0800 [thread overview]
Message-ID: <1196378080.18851.116.camel@localhost> (raw)
In-Reply-To: <20071129214828.GD20882@us.ibm.com>
On Thu, 2007-11-29 at 13:48 -0800, Nishanth Aravamudan wrote:
> __GFP_NOFAIL means repeat forever
>
> order <= PAGE_ALLOC_COSTLY_ORDER means __GFP_NOFAIL
If this is true, why do we still pass in __GFP_REPEAT to the pgd_alloc()
functions (at least in x86's pgalloc_64.h and pgtable_32.c). We don''t
ever have pagetables exceeding PAGE_ALLOC_COSTLY_ORDER, do we?
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-11-29 22:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 21:48 [PATCH] mm: fix confusing __GFP_REPEAT related comments Nishanth Aravamudan
2007-11-29 23:14 ` Dave Hansen [this message]
2007-11-30 4:19 ` Nishanth Aravamudan
2007-11-30 18:27 ` Dave Hansen
2007-11-30 17:43 ` Nishanth Aravamudan
2007-11-30 18:31 ` Dave Hansen
2007-12-02 11:58 ` William Lee Irwin III
2007-12-03 18:06 ` Nishanth Aravamudan
-- strict thread matches above, loose matches on Subject: below --
2007-11-20 1:10 Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196378080.18851.116.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=linux-mm@kvack.org \
--cc=mel@skynet.ie \
--cc=nacc@us.ibm.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).