From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id DA2C36B00CD for ; Mon, 23 Mar 2009 05:37:51 -0400 (EDT) From: David Howells In-Reply-To: <1237752784-1989-2-git-send-email-hannes@cmpxchg.org> References: <1237752784-1989-2-git-send-email-hannes@cmpxchg.org> <20090321102044.GA3427@cmpxchg.org> Subject: Re: [patch 2/3] ramfs-nommu: use generic lru cache Date: Mon, 23 Mar 2009 10:40:42 +0000 Message-ID: <11989.1237804842@redhat.com> Sender: owner-linux-mm@kvack.org To: Johannes Weiner Cc: dhowells@redhat.com, Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nick Piggin , KOSAKI Motohiro , Rik van Riel , Peter Zijlstra , MinChan Kim , Lee Schermerhorn List-ID: Johannes Weiner wrote: > Instead of open-coding the lru-list-add pagevec batching when > expanding a file mapping from zero, defer to the appropriate page > cache function that also takes care of adding the page to the lru > list. > > This is cleaner, saves code and reduces the stack footprint by 16 > words worth of pagevec. Acked-by: David Howells -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org