From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF817C7EE31 for ; Tue, 24 Jun 2025 11:44:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F28D6B00B6; Tue, 24 Jun 2025 07:44:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A2ED6B00B7; Tue, 24 Jun 2025 07:44:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 691AD6B00B9; Tue, 24 Jun 2025 07:44:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5A4776B00B6 for ; Tue, 24 Jun 2025 07:44:11 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C579BC059B for ; Tue, 24 Jun 2025 11:44:10 +0000 (UTC) X-FDA: 83590110660.29.DD80C36 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 6CC9420006 for ; Tue, 24 Jun 2025 11:44:08 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gp+nVjod; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750765448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mWIxS9YRc3nZx7A+TXGsN2wq57/2Fy5jMiTU7iuOoO4=; b=1dLEW7NANBcjODbCfaw/IidGeIr2xO2ToL+WUH58ehGi6XowmzlN3Eu60ii2eJTAGkDH43 OIVhjFtxB4KC+IwtiIRk67agANoibqxol5qtsw/N/5n2NIESDuQvCfPhSqsU26syEYRDyt CaBkliNtq5urNPPsPtmu5tTGY9cLCqc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gp+nVjod; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750765448; a=rsa-sha256; cv=none; b=uS+6kXY+CyRRaNuHikWswFWbzumgc8YFPDmZLqMZgY04KSzyTfTd/q4atdPWiOSgZkeZnF Y1SXmFH5hmedjq6uo+e9Gp3GNGSuY7iEODaWCufZTR8a2pbDQaj5Wdbq+FIPxEz2ixzXR1 +f1RIUQgIAWe8PMxtj4FUHTgZ4auZcE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750765447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mWIxS9YRc3nZx7A+TXGsN2wq57/2Fy5jMiTU7iuOoO4=; b=gp+nVjodh1wQw52PaXN/EDkgJK7ibcvHfNbxg7KhH3SjygmIoUnxp1kRKrygSz7/hAbPTq JJpNbax6Okkx8EgI4LS8W89ly8WiH2S3uIcTNk+QnVvJHAzOxodMKIIXVxYz/duvKE+fY3 JxX3iGIzMsvke+n7tDeow9cwc4opdeA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-L9DCqEaSNTGlcy8SvVZw1Q-1; Tue, 24 Jun 2025 07:44:06 -0400 X-MC-Unique: L9DCqEaSNTGlcy8SvVZw1Q-1 X-Mimecast-MFC-AGG-ID: L9DCqEaSNTGlcy8SvVZw1Q_1750765445 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4537f56ab74so2366085e9.3 for ; Tue, 24 Jun 2025 04:44:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750765445; x=1751370245; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mWIxS9YRc3nZx7A+TXGsN2wq57/2Fy5jMiTU7iuOoO4=; b=RRmePv8CCfbxbuIG/7c6YBHTGTCmVhn0AZeEUXxPeKg37T8/Aa6zw05fb4j8J5PuFd D2P3BTv6LWZqeZKV0NBHnQtUtvIfZXEJfZyENBtm/um+UJkQNgetKCKFaliekTRPnlIm iFQehd1TotK1/iqRgLDhvHsKhEqcUePgH1S4TIOp6xHdiegPgNIXLj5a/JusVCUu0gKs 9kDIu8tPP3pF0zQODMQBz6uYSHMlalR9qoAv5+USnxOYxVvxv9mPLaxzB/Ejc4OIHzeO Lyj9598Zua3dYrTLvGjnZ9OU70cI4newre/f1O1gUcKjex3KSQG2rr7rheAZALqY2ZQi FiVw== X-Forwarded-Encrypted: i=1; AJvYcCViR0JsjE19yqSqNUp+Ic+UNH54lyKBujzrRUb8ulGjkhQjElLgbsmoklY34M/+GKSOFhdv8m8Ljw==@kvack.org X-Gm-Message-State: AOJu0YzktWr8TbPyfHkTrAxa9reGIDjecpVORMEoUBRhGe14p3CHO8bj eczwcwQ5e8JccEw0/KdyLFilgJMmt8XmvWixyTyv6O+foSJM3i3s2Hvo//aTtaCwaLOWMm1XTs8 lDAhLnQyu3cuEpBUyhR8e++l11V1isO5ZmeC2HVkfKQOC6gcMpR0t X-Gm-Gg: ASbGncvnquDL1jXWBgbh33ySEBWCYYq2TH/0Ba5C89NxMLH24rI+Y4GTjWwX5ykHtFX K1vnCe0j7wFDB7CY9LpKoHArZaAU8GFynI9VG0jVjFpHw8q0koq/NIsqpC10ewh3mnx2r8I92ji rMKwmINGCaQHRM2lw7TUzXhgJXScYWBBCflxe4Eo4ixkuWP1AeQlTk5Qb19kL2CVGX2wW4qg1Yw +AcB8oJbjxkk/WEqZeBQ8qsVK/so4HQ12aWJSpMmG1W+v9wbnBx0/8I5EvxkG7rLgafiskr7gFz HtS9cfUcp6cY1MDTmttcc2B6cY8+e+Kaeu8aM2yAKx46p1/xCdEDsVU= X-Received: by 2002:a05:600c:a016:b0:450:ceb2:67dd with SMTP id 5b1f17b1804b1-45365a0026dmr138204105e9.33.1750765445119; Tue, 24 Jun 2025 04:44:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGu2tGkM7OI2Bjjt9QwycoZQ3Rtbqmwt/+aXANf/vpkZTdvOWQBqbd7keMeDPMxBFE50VeBMw== X-Received: by 2002:a05:600c:a016:b0:450:ceb2:67dd with SMTP id 5b1f17b1804b1-45365a0026dmr138203425e9.33.1750765444628; Tue, 24 Jun 2025 04:44:04 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e805e828sm1794502f8f.32.2025.06.24.04.44.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jun 2025 04:44:03 -0700 (PDT) Message-ID: <11b23ea3-cadd-442b-88d7-491bba99dabe@redhat.com> Date: Tue, 24 Jun 2025 13:44:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 00/18] KVM: Mapping guest_memfd backed memory at the host for software protected VMs To: Fuad Tabba Cc: Sean Christopherson , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250611133330.1514028-1-tabba@google.com> <80e062dd-2445-45a6-ba4a-8f5fe3286909@redhat.com> <372bbfa5-1869-4bf2-9c16-0b828cdb86f5@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8gXFACohMKsp1nO_SMix46yQaRGsPvfsw1UtZQHuOZE_1750765445 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6CC9420006 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: ibbgnnshsxi53wu3um8un6uz9hrswyxy X-HE-Tag: 1750765448-851712 X-HE-Meta: U2FsdGVkX1/0f84dA+l9Bxg3GnifEEYzI54uCOogYxcqm4/UsFWW/hkrX0AgpbCInpQ+NuYlLrGOWr9ykL2mNvxXgh46w565wve6aSIEosP/srHBHFBeu0px3ZfgadacAcPzJDbMTIdRikmDQY0su2eB2WPDQzMjkYOGj0l1J5fYUfANNY3cKJvLJ05zfyhUgwQtBr5iPR1L+tlIXFHX2/b/gNnQ0psYxIUNrV4PCQCTr4lJRkvoaTK4lCEumBtroSwNOzpFY++Rle76AesunZ3bpDT1g9lbxGfSy5ibq3PWF8/Otl8XyRlFvfAIoIVQgz7xr51+kTy4dcD77GENQ6SDRlt572emIRyW3azPHuPWhKghilmigfJBN2R5Ljl3HEQ4lGt4cO/RJlr+O8xE6NDAADP4aPQ1aNtElem/AxUbK93UsV9HDmcdOH9vuv9DJ1HsgMd01v3PtsT6JoG8ScQ6JmLbe3lugXr6wuVlpgUS2dE/YnCio6vomLRYRGciB8yqBaHRS4k/rOJFirc2kU/EWmO3i4zS5jsEyK5lyBYLeBjiyv6B3FTAG7krRUYDQo8re+14zjICecClNnv9Q9F8ZEHIToRcfRcgrqZ24/9JZfUcXD9aE7rwFAXvsFgBW7vHzTf6q3bJciYvQzUyL6+or6A9a0FOpcpMhujTB9gN9mwFXrGZ2j0HP8Et5XBQDNvxkWNlLqWDYsReRpSAy3bdi7a8k6VMMqk4iptGcmnLFrfhlcViQPOUCaqWKFVtCdlvB8Td3v8zfV+s5EoliD0aoG+cVNMFkHvB35uD55WZ3mh7Nfx83SjX24PQpwAMd74e2YJKeO/GoT1PAk2hOeXIYE8+m7MaV4SlGJ9USxxG/eB8BylONli3EdFJdJnJK9NrWpyZiRk3DnU+MSz5XY4l2TjwRCtbrB0KRg1aHJEsNVNKrYCU97w27Ot3TY8ieEKwUv9ITzuXaAjWGvI 7tHFutNC 0yHPBCQDHaU/eEwqGnG436YcIpxbUiPPsQv6thYPQ2OvIFOxUOvxEPCnvY/r4ZOQ+JA3HbbdVSjiK4vm7JFypVPvxKjBtHCvK9hrG5CXTQb1QYPwrJFy2R+7bFFjsVwoIb5zRf2nk8O6AX3q/KrGW6GECOINLyWbeN0KI2WCWl5Vg7S/97dDMsfOM08xBHsmj1a9OCiQiQmk4Sn56GmY1t5Tbv0s2VnfftLWqChUXBoup3Wnoe5kwdfgmZeu2rtaOp94Auy4/uiq48Jcf2ojr05fs+fWgq9K9SWM2pvnw9/MYikxc0IgVcdm4m8CUzi6eKkdearfokH/eUtj5rF5eGMPNUfIhw23u5hqnNoNvAWnHxjJrkriJzdLO2cFtQUIRpDVbsut+kpDMDGt1+fnIWAWneDkk0yL0nANZl/rpW/7EAegVERbC2VQcQ+NuwFStfqk8JrfYIQ9HC1eOTyQZ9+MKwnbcPOg/PXagO0826tGyNTJrdiBACWFKVKCelJjCAZAcm1l8aoTXY0K3MBgUuC1F9f+itvjeD8K7psNRXzu1xRlKPS+fL+A5JpWORx6IX3u/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.06.25 12:25, Fuad Tabba wrote: > Hi David, > > On Tue, 24 Jun 2025 at 11:16, David Hildenbrand wrote: >> >> On 24.06.25 12:02, Fuad Tabba wrote: >>> Hi, >>> >>> Before I respin this, I thought I'd outline the planned changes for >>> V13, especially since it involves a lot of repainting. I hope that >>> by presenting this first, we could reduce the number of times I'll >>> need to respin it. >>> >>> In struct kvm_arch: add bool supports_gmem instead of renaming >>> has_private_mem >>> >>> The guest_memfd flag GUEST_MEMFD_FLAG_SUPPORT_SHARED should be >>> called GUEST_MEMFD_FLAG_MMAP >>> >>> The memslot internal flag KVM_MEMSLOT_SUPPORTS_GMEM_SHARED should be >>> called KVM_MEMSLOT_SUPPORTS_GMEM_MMAP >>> >>> kvm_arch_supports_gmem_shared_mem() should be called >>> kvm_arch_supports_gmem_mmap() >>> >>> kvm_gmem_memslot_supports_shared() should be called >>> kvm_gmem_memslot_supports_mmap() >>> >>> kvm_gmem_fault_shared(struct vm_fault *vmf) should be called >>> kvm_gmem_fault_user_mapping(struct vm_fault *vmf) >>> >>> The capability KVM_CAP_GMEM_SHARED_MEM should be called >>> KVM_CAP_GMEM_MMAP >>> >>> The Kconfig CONFIG_KVM_GMEM_SHARED_MEM should be called >>> CONFIG_KVM_GMEM_SUPPORTS_MMAP >> >> Works for me. >> >>> >>> Also, what (unless you disagree) will stay the same as V12: >>> >>> Rename CONFIG_KVM_PRIVATE_MEM to CONFIG_KVM_GMEM: Since private >>> implies gmem, and we will have additional flags for MMAP support >> >> Agreed. >> >>> >>> Rename CONFIG_KVM_GENERIC_PRIVATE_MEM to >>> CONFIG_KVM_GENERIC_GMEM_POPULATE >> >> Agreed. >> >>> >>> Rename kvm_slot_can_be_private() to kvm_slot_has_gmem(): since >>> private does imply that it has gmem >> >> Right. It's a little more tricky in reality at least with this series: >> without in-place conversion, not all gmem can have private memory. But >> the places that check kvm_slot_can_be_private() likely only care about >> if this memslot is backed by gmem. > > Exactly. Reading the code, all the places that check > kvm_slot_can_be_private() are really checking whether the slot has > gmem. After this series, if a caller is interested in finding out > whether a slot can be private could achieve the same effect by > checking that a gmem slot doesn't support mmap (i.e., > kvm_slot_has_gmem() && kvm_arch_supports_gmem_mmap() ). If that > happens, we can reintroduce kvm_slot_can_be_private() as such. > > Otherwise, I could keep it and already define it as so. What do you think? > >> Sean also raised a "kvm_is_memslot_gmem_only()", how did you end up >> calling that? > > Good point, I'd missed that. Isn't it true that > kvm_is_memslot_gmem_only() is synonymous (at least for now) with > kvm_gmem_memslot_supports_mmap()? Yes. I think having a simple kvm_is_memslot_gmem_only() helper might make fault handling code easier to read, though. -- Cheers, David / dhildenb