From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A8F0C61CE8 for ; Thu, 12 Jun 2025 17:00:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9889D6B008C; Thu, 12 Jun 2025 13:00:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9601E6B0092; Thu, 12 Jun 2025 13:00:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84EA16B0093; Thu, 12 Jun 2025 13:00:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6668A6B008C for ; Thu, 12 Jun 2025 13:00:11 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1755CC1649 for ; Thu, 12 Jun 2025 17:00:11 +0000 (UTC) X-FDA: 83547361422.15.D2BB184 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 6C9E41C000E for ; Thu, 12 Jun 2025 17:00:08 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OXUkrw29; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749747608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bE67YPqM8h5nTd6o6AkCh2yLeaxlPhQSOyCDAtjQSEY=; b=S/PeybpaqVjhrcXH+OhKYCNfRK+0F1z2KLoN+43lO3QMPlGuajU7zIbBKNsl9Okt7DWmkm nLqAzT538E+0AHbZbPNd828XNeqBwOhL03acWXUKIskdSnt+7MD7ceSTcGyDhQrUYhYP7u tnGYlxvlZLy7mu1EKkSP3rpYVZppsoc= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OXUkrw29; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749747608; a=rsa-sha256; cv=none; b=qV06zPRJgkCio3F/fjE6xBcPFmnl8CGt6gKCctxGI5VoxmYy1OnLK/SLxTO6HbWI/qk6YI W5euh5k2zKQqe3wv9JC2TNMScwyzSndbOFXAdzv82pfKHnvscqnABhXHmd12utZVCM80j9 BoBQlp6KYKLuXAk8GVd6YQCP9xIG1eY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749747607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bE67YPqM8h5nTd6o6AkCh2yLeaxlPhQSOyCDAtjQSEY=; b=OXUkrw29k173jAbxN0uuvC9nYiFPI84X8ubFZcPY6/UJobtxNpDYrgaDSFod4FluutvCKx U7PrfQTX1M0gDGyc0XQYDYGsRSr2RkMJ2UXhdK1bCyt28pHi0mzZowiPsaLQ5T90sv91YH ybothjgu5UlgeUWFSt5Ra6GVjx5+/lw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-qbGTcKdRM_q8IGnIQGXBHg-1; Thu, 12 Jun 2025 13:00:04 -0400 X-MC-Unique: qbGTcKdRM_q8IGnIQGXBHg-1 X-Mimecast-MFC-AGG-ID: qbGTcKdRM_q8IGnIQGXBHg_1749747603 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-451d5600a54so10650165e9.2 for ; Thu, 12 Jun 2025 10:00:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749747603; x=1750352403; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bE67YPqM8h5nTd6o6AkCh2yLeaxlPhQSOyCDAtjQSEY=; b=W7iw599rormf2cdptPKQCxKwjotQw2wSOV4t/hzsHfDI77n19bKmKoXyfWSvr8d+GG qUlasHJ96vFh7B4jhQOp8ObPxupivYnO4lOGQk3T9nd8jNY1PJB7bHgWnvUCw4OWWggs IL/jDBubVRKs0Pba1c2/PQ1fxq3ckJ8hcUyW4sKlT5otXDdQDzZBFp6smJNc6HrOyJG0 QtSqthfblzosh7ifBGCmc5/F6Fim6lypWjYaHpZg3M+rG9hbFVXQYWp0XTmphGB7+nYh pVOJpGnCNpacMnxh7Gb0O1WPvadKaVSTlqbtMOAU3+siyWDND1XXpBlbkXmraqP3b3vC Nrqw== X-Forwarded-Encrypted: i=1; AJvYcCVKH82Ic1vKY7v1cmunZz5Wdq9vk6PsOvqo+z3jm2LixIeQxkJYGMQwIajYfnPUwyQo9iJjG4jc5Q==@kvack.org X-Gm-Message-State: AOJu0YyfUKBlEvpAzOm/oQ08NTv/7KnqPB87XGxR/i+tjAXW16wJr7g7 eHi8Y6WBcN7lrLTqIpFRyynMmx3d/zEyzldLtJzhZh9WN2mrMb3qgLAQfUhaeI5rnXqSwtOWXoE E9UQXup8yWx/jpaeO2sAlTY4ncpE+d+rBynT45LMNOVcjCG06xwE/ X-Gm-Gg: ASbGnctkP9eKddjHCin2ZHLH5GE9hFS4/ycEQvBxl8bCldFYW9o0pSkLjEDLe/h9Z0i i0M50+LxR3a+wAvc657y8zdZbo8KQqCeXGZhlg+mfMjMwqb01Y1eBt78VUlLMlcgxB7vACOqMD2 /lMi0TCPqp1rW1Y8cVnUO4XN/H9BRmWRHLoeSNL9Mndv0Pz8vQHX0D5xauOiIrwS8Njl4tZuwFu U4qKgRB5Ehpl8+fB0XNJOzoYB48r6T1Kfj+JTL+XBJoY0UxSKCOCYkgdrnjSllNWy1WzFkYr47f rV9vEU7SMgZoKZcG+gBir9xmE5lw2w+hH/DRFOdw0rTuIBJIp9+eKigM44nZr+6eVBNNAdTOBR4 /nvoQ51vtNa+FOpdjiWS1dDjK0YDFChzlpLE9sz5xpZHUwkPE2Q== X-Received: by 2002:a05:600c:4f42:b0:451:833f:483c with SMTP id 5b1f17b1804b1-4532486c6bamr73197805e9.7.1749747603158; Thu, 12 Jun 2025 10:00:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTIa0Dl921K1lO5JZx/PA/Nioq8Af8exEqIs0sIWSYqdOJ/hXH8JgoXnVT7MAlXDsJZzZs+Q== X-Received: by 2002:a05:600c:4f42:b0:451:833f:483c with SMTP id 5b1f17b1804b1-4532486c6bamr73197495e9.7.1749747602738; Thu, 12 Jun 2025 10:00:02 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:1e00:1e1e:7a32:e798:6457? (p200300d82f2c1e001e1e7a32e7986457.dip0.t-ipconnect.de. [2003:d8:2f2c:1e00:1e1e:7a32:e798:6457]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a5619ab781sm2473119f8f.43.2025.06.12.10.00.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jun 2025 10:00:02 -0700 (PDT) Message-ID: <11d1ff4d-3f75-42a5-968e-8f4bad84ab78@redhat.com> Date: Thu, 12 Jun 2025 19:00:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pud() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Oscar Salvador References: <20250611120654.545963-1-david@redhat.com> <20250611120654.545963-4-david@redhat.com> <177cb5d1-4fde-4fa0-adbc-8e295fba403b@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <177cb5d1-4fde-4fa0-adbc-8e295fba403b@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: P-oT1U56myIzFfTOWA4fH2wYYMmew-RY6xvxinfvmXM_1749747603 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 3azsujmzhef9jkrshzsygaf7mi8yqyzo X-Rspamd-Queue-Id: 6C9E41C000E X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1749747608-126982 X-HE-Meta: U2FsdGVkX1/c/xs4skp52hf4tFFNnoEPzbpPufQ9BeCi4ZNyvM6uF2e6wdfMPvIqLJly8ih+m9Ytnyf8SEfJPWV4GCCkiJIA3i2QUCBRK3S6vA1f9vJsIyk+aVEXdwkZO2QkvvAAze/mF3apwTNyY9yEkoPTj0NlXZ4LP4koEUIgnutMJ+wTtOf/8nbIuhHTQ66xn9iQC9Dit4zfItOjC4cU3v/YVtD0wwoBT4YI8geYLtnlLDx4XbFs7J3wjuCKPb33ZgcGPUwNMeV3epPbmVgQdE2omiNZxf1jQCMn6TmvHHRMHIjYKrgyj/EJqWItgCV9l3/mZs7K+mWPJ3upgbDZ8NGCdE13KA5NkxWZ5+QamBjPVVXUPGoPhKZ1A8k+YOhjVPHQg3hzLdQEQReH+42kbAdiH4tpjQGPAlDNcWlt1ommtqdz7eNL9BK5UvNsQbghq4VpVHT2cu5TrYzxt3V49bErKGhSdOVdPmk/x73Qhfk9+klHMJTddQqZI+Nz2PI8Y+pC+hRtyxtDK68kazOmL29FLlJD1SZPm4jITs95YIhPgCGTuqyRLODXGVJZB72KPdShsyamjPgDn4/VbozOC6oL4crP/F08njjbj6JClx7SaC/JwoyierHDiwTZHJVDOzvxabqZQLxgU4syNHf6wqtfEnsHnLTt3uIyKmqeK9Wxvnfs0KI0SmwJFb85Nw+76b6B6ZV9GvROXzJN/CpV0LYoLaNRP6otPulbKDLUfGmYkvnvayDtHoQ5rDYB4YvxJtndffqh1DaM9g43Ygolbdps7owWrG6aFHijXtaB2DjGP8a+m3J4cOdLBFWq82i2IOFyeX0EEZwWruDm5QrqeZ9NdUTAc3ad8V69na/IgIlz7f92WtsArZpYT43D49uvksGvYw1yqnIFTLXTRh3jhDQ31m83OWf+T6JsPPmOZOD4fZ+qXWs+0WYtO9u6s4QCymM19QLADeimqdT 341Bop/f lbptitP2g/itM/ZpY793SwGAYBiMBeDomYmm2eegy7leYrR4lWcbdYb2lFmCd4Ay//zKhS6YtcSQmVsW1EH4BcFnUyfBi/2F1OFTX1Ne3TXzL16QYCyqOKlzXwyUgCd5nkhWLPApX+MJ2hXvWjQqdMxGtujPJ86pFwpFHQNPl5Rhij7jmHV3Fi9nezI+8AcSnXzD/EFJ+OSrQ+ZEiTAl7tnE1a4fAyJ+7SQmd+m7zUqgPcOjp4sjl6eZjtgiso9N0+U5M3i3zHnbqB9Sg++ID7yzK5U8aReSoKKPyB0HY9rCbeEpjq/BUzxxK6qJGcS6XB3HLto7hWAJgK+ZeCEWvYekx1aiGevPqOO9DLiqHfZLOqjwx2fTeQXOFjwg0vPmd7bviXMiORCuPKikLlsWA/p5BQxvEcST7yoV8HoJ0243dEQY5Lbj3C9z3d5NdeZ+tZl8jMtFqikkygtk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.06.25 18:49, Lorenzo Stoakes wrote: > On Wed, Jun 11, 2025 at 02:06:54PM +0200, David Hildenbrand wrote: >> Marking PUDs that map a "normal" refcounted folios as special is >> against our rules documented for vm_normal_page(). > > Might be worth referring to specifically which rule. I'm guessing it's the > general one of special == don't touch (from vm_normal_page() comment): > > /* > * vm_normal_page -- This function gets the "struct page" associated with a pte. > * > * "Special" mappings do not wish to be associated with a "struct page" (either > * it doesn't exist, or it exists but they don't want to touch it). In this > * case, NULL is returned here. "Normal" mappings do have a struct page. > * > * ... > * > */ Well, yes, the one vm_normal_page() is all about ... ? :) > > But don't we already violate this E.g.: > > if (vma->vm_ops && vma->vm_ops->find_special_page) > return vma->vm_ops->find_special_page(vma, addr); > > I mean this in itself perhaps means we should update this comment to say 'except > when file-backed and there is a find_special_page() hook'. I rather hope we severely break this case such that we can remove that hack. Read as in: I couldn't care less about this XEN hack, in particular, not documenting it. I was already wondering about hiding it behind a XEN config so not each and every sane user of this function has to perform this crappy-hack check. [...] >> } >> >> - entry = pud_mkhuge(pfn_t_pud(pfn, prot)); >> - if (pfn_t_devmap(pfn)) >> - entry = pud_mkdevmap(entry); >> - else >> - entry = pud_mkspecial(entry); >> + if (fop.is_folio) { >> + entry = folio_mk_pud(fop.folio, vma->vm_page_prot); >> + >> + folio_get(fop.folio); >> + folio_add_file_rmap_pud(fop.folio, &fop.folio->page, vma); >> + add_mm_counter(mm, mm_counter_file(fop.folio), HPAGE_PUD_NR); > > Nit, but might be nice to abstract for PMD/PUD. Which part exactly? Likely a follow-up if it should be abstracted. > >> + } else { >> + entry = pud_mkhuge(pfn_t_pud(fop.pfn, prot)); > > Same incredibly pedantic whitespace comment from previous patch :) ;) -- Cheers, David / dhildenb