From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e35.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m1CLvKYq010443 for ; Tue, 12 Feb 2008 16:57:20 -0500 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m1CLvB4K100740 for ; Tue, 12 Feb 2008 14:57:14 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m1CLvAue026940 for ; Tue, 12 Feb 2008 14:57:10 -0700 Subject: Re: [-mm PATCH] register_memory/unregister_memory clean ups From: Dave Hansen In-Reply-To: <1202853415.25604.59.camel@dyn9047017100.beaverton.ibm.com> References: <20080211114818.74c9dcc7.akpm@linux-foundation.org> <1202765553.25604.12.camel@dyn9047017100.beaverton.ibm.com> <20080212154309.F9DA.Y-GOTO@jp.fujitsu.com> <1202836953.25604.42.camel@dyn9047017100.beaverton.ibm.com> <1202849972.11188.71.camel@nimitz.home.sr71.net> <1202853415.25604.59.camel@dyn9047017100.beaverton.ibm.com> Content-Type: text/plain Date: Tue, 12 Feb 2008 13:57:14 -0800 Message-Id: <1202853434.11188.76.camel@nimitz.home.sr71.net> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Badari Pulavarty Cc: Yasunori Goto , KAMEZAWA Hiroyuki , Andrew Morton , lkml , greg@kroah.com, linux-mm List-ID: On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote: > > +static void __remove_section(struct zone *zone, unsigned long > section_nr) > +{ > + if (!valid_section_nr(section_nr)) > + return; > + > + unregister_memory_section(__nr_to_section(section_nr)); > + sparse_remove_one_section(zone, section_nr); > +} I do think passing in a mem_section* here is highly superior. It makes it impossible to pass a pfn in and not get a warning. -- Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org