From: Dave Hansen <haveblue@us.ibm.com>
To: balbir@linux.vnet.ibm.com
Cc: linux-mm@kvack.org, Hugh Dickins <hugh@veritas.com>,
Sudhir Kumar <skumar@linux.vnet.ibm.com>,
YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
Paul Menage <menage@google.com>,
lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
taka@valinux.co.jp, David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [RFC][2/3] Account and control virtual address space allocations
Date: Tue, 18 Mar 2008 10:11:16 -0700 [thread overview]
Message-ID: <1205860276.8872.20.camel@nimitz.home.sr71.net> (raw)
In-Reply-To: <47DF1760.9030908@linux.vnet.ibm.com>
On Tue, 2008-03-18 at 06:44 +0530, Balbir Singh wrote:
> > If you're going to do this, I think you need a couple of phases.
> >
> > 1. update the vm_(un)acct_memory() functions to take an mm
>
> There are other problems
>
> 1. vm_(un)acct_memory is conditionally dependent on VM_ACCOUNT. Look at
> shmem_(un)acct_size for example
Yeah, but if VM_ACCOUNT isn't set, do you really want the controller
accounting for them? It's there for a reason. :)
The shmem_acct_size() helpers look good. I wonder if we should be using
that kind of things more generically.
> 2. These routines are not called from all contexts that we care about (look at
> insert_special_mapping())
Could you explain why "we" care about it and why it isn't accounted for
now?
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-18 17:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-16 17:29 [RFC][0/3] Virtual address space control for cgroups Balbir Singh
2008-03-16 17:29 ` [RFC][1/3] Add user interface for virtual address space control Balbir Singh
2008-03-16 17:30 ` [RFC][2/3] Account and control virtual address space allocations Balbir Singh
2008-03-17 2:02 ` Paul Menage
2008-03-17 2:57 ` Balbir Singh
2008-03-17 3:03 ` Paul Menage
2008-03-17 11:36 ` Pavel Emelyanov
2008-03-17 12:29 ` Balbir Singh
2008-03-17 12:40 ` Pavel Emelyanov
2008-03-17 12:51 ` Balbir Singh
2008-03-17 13:01 ` Pavel Emelyanov
2008-03-17 14:39 ` Balbir Singh
2008-03-17 16:53 ` Dave Hansen
2008-03-18 1:14 ` Balbir Singh
2008-03-18 17:11 ` Dave Hansen [this message]
2008-03-18 17:58 ` Balbir Singh
2008-03-17 23:35 ` YAMAMOTO Takashi
2008-03-18 1:10 ` Balbir Singh
2008-03-16 17:30 ` [RFC][3/3] Update documentation for virtual address space control Balbir Singh
2008-03-16 18:32 ` Randy Dunlap
2008-03-17 1:33 ` Balbir Singh
2008-03-16 23:26 ` [RFC][0/3] Virtual address space control for cgroups Paul Menage
2008-03-17 1:47 ` Li Zefan
2008-03-17 1:57 ` Paul Menage
2008-03-17 5:08 ` Balbir Singh
2008-03-17 5:22 ` Paul Menage
2008-03-17 15:15 ` Balbir Singh
2008-03-17 1:50 ` Balbir Singh
2008-03-17 1:55 ` Paul Menage
2008-03-17 3:12 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205860276.8872.20.camel@nimitz.home.sr71.net \
--to=haveblue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=rientjes@google.com \
--cc=skumar@linux.vnet.ibm.com \
--cc=taka@valinux.co.jp \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).