From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>, Mel Gorman <mel@csn.ul.ie>,
Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org
Subject: Re: [patch 5/9] slub: Fallback to minimal order during slab page allocation
Date: Fri, 21 Mar 2008 13:14:17 +0800 [thread overview]
Message-ID: <1206076457.14496.85.camel@ymzhang> (raw)
In-Reply-To: <Pine.LNX.4.64.0803202034340.14239@schroedinger.engr.sgi.com>
On Thu, 2008-03-20 at 20:35 -0700, Christoph Lameter wrote:
> On Fri, 21 Mar 2008, Zhang, Yanmin wrote:
>
> > > However, its a division in a potentially hot codepath.
> > No as long as there is no allocation failure because of fragmentation.
>
> If its only used for the fallback path then the race condition is still
> there?
I can't understand your question. Does it means min_objects? It's not related
to the race. The fallback path also isn't related to the race.
The race is when kernel runs in allocate_slab, just between fetching s->order and
s->objects,user might change s->order by sysfs.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-21 5:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080317230516.078358225@sgi.com>
[not found] ` <20080317230528.279983034@sgi.com>
2008-03-19 9:09 ` [patch 2/9] Store max number of objects in the page struct Zhang, Yanmin
2008-03-19 17:49 ` Christoph Lameter
2008-03-20 3:32 ` Zhang, Yanmin
2008-03-20 21:05 ` Christoph Lameter
2008-03-21 22:24 ` Andrew Morton
2008-03-22 3:27 ` Ben Pfaff
2008-03-24 1:22 ` [PATCH] Add definitions of USHORT_MAX and others Zhang, Yanmin
[not found] ` <20080317230528.939792410@sgi.com>
2008-03-20 5:10 ` [patch 5/9] slub: Fallback to minimal order during slab page allocation Zhang, Yanmin
2008-03-20 18:29 ` Christoph Lameter
2008-03-21 0:52 ` Zhang, Yanmin
2008-03-21 3:35 ` Christoph Lameter
2008-03-21 5:14 ` Zhang, Yanmin [this message]
2008-03-21 6:07 ` Christoph Lameter
2008-03-21 8:23 ` Zhang, Yanmin
[not found] ` <20080317230529.701336582@sgi.com>
2008-03-20 5:53 ` [patch 8/9] slub: Make the order configurable for each slab cache Zhang, Yanmin
2008-03-20 18:31 ` Christoph Lameter
2008-03-20 23:57 ` Christoph Lameter
[not found] ` <20080317230529.474353536@sgi.com>
2008-03-18 18:54 ` [patch 7/9] slub: Adjust order boundaries and minimum objects per slab Pekka Enberg
2008-03-18 19:00 ` Christoph Lameter
2008-03-19 1:04 ` Zhang, Yanmin
2008-03-19 15:20 ` Pekka Enberg
2008-03-20 6:44 ` Zhang, Yanmin
2008-03-20 18:32 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206076457.14496.85.camel@ymzhang \
--to=yanmin_zhang@linux.intel.com \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).