From: Matt Helsley <matthltc@us.ibm.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@tv-sign.ru>,
David Howells <dhowells@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Christoph Hellwig <chellwig@de.ibm.com>,
Hugh Dickins <hugh@veritas.com>
Subject: Re: [PATCH] procfs task exe symlink
Date: Wed, 30 Apr 2008 04:02:38 -0700 [thread overview]
Message-ID: <1209553358.29759.24.camel@localhost.localdomain> (raw)
In-Reply-To: <20080426162458.GJ5882@ZenIV.linux.org.uk>
On Sat, 2008-04-26 at 17:24 +0100, Al Viro wrote:
> On Sat, Apr 26, 2008 at 09:19:30AM -0700, Andrew Morton wrote:
>
> > + set_mm_exe_file(bprm->mm, bprm->file);
> > +
> > /*
> > * Release all of the old mmap stuff
> > */
> >
> > However I'd ask that you conform that this is OK. If set_mm_exe_file() is
> > independent of unshare_files() then we're OK. If however there is some
> > ordering dependency then we'll need to confirm that the present ordering of the
> > unshare_files() and set_mm_exe_file() is correct.
>
> No, that's fine (unshare_files() had to go up for a lot of reasons, one
> of them being that it can fail and de_thread() called just above is
> very much irreversible).
They are independent. It just needs to be called before exec_mmap() --
so your fix looks good.
Cheers,
-Matt Helsley
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-04-30 10:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 1:44 [PATCH] procfs task exe symlink Matt Helsley
2008-02-16 12:12 ` Mike Frysinger
2008-02-19 21:54 ` Matt Helsley
2008-02-20 4:02 ` Mike Frysinger
2008-04-26 16:19 ` Andrew Morton
2008-04-26 16:24 ` Al Viro
2008-04-30 11:02 ` Matt Helsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209553358.29759.24.camel@localhost.localdomain \
--to=matthltc@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=chellwig@de.ibm.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleg@tv-sign.ru \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).