linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: David Howells <dhowells@redhat.com>,
	Paul Mundt <lethal@linux-sh.org>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	linux-mm@kvack.org
Subject: Re: [PATCH] nommu: Push kobjsize() slab-specific logic down to ksize().
Date: Tue, 20 May 2008 14:14:56 -0500	[thread overview]
Message-ID: <1211310896.18026.214.camel@calx> (raw)
In-Reply-To: <Pine.LNX.4.64.0805201206040.10964@schroedinger.engr.sgi.com>

On Tue, 2008-05-20 at 12:08 -0700, Christoph Lameter wrote:
> On Tue, 20 May 2008, Matt Mackall wrote:
> 
> > > Remove kobjsize completely and replace with calls to ksize? Callers must 
> > > not call ksize() on non slab objects.
> > 
> > What'd you think of my idea of adding WARN_ONs to SLAB and SLUB for
> > these cases? That is, warn whenever ksize() gets a non-kmalloced
> > address?
> 
> How would that work given that both SLUB and SLOB forward >4k allocs to 
> the page allocator? So any compound page allocation may be a slab 
> allocation. Is there some way to distinguish between a 
> allocations of the page allocator and a slab alloc?

We can't do it at all for SLOB. But when debugging is turned on, we can
notice (in SLAB and SLUB) whenever anyone asks for the ksize() of
something that lives on a non-kmalloc slab.

-- 
Mathematics is the supreme nostalgia of our time.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-05-20 19:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20  9:59 [PATCH] nommu: Push kobjsize() slab-specific logic down to ksize() Paul Mundt
2008-05-20 15:18 ` David Howells
2008-05-20 16:52   ` Christoph Lameter
2008-05-20 18:23     ` Matt Mackall
2008-05-20 18:51       ` Christoph Lameter
2008-05-20 19:00         ` Matt Mackall
2008-05-20 19:08           ` Christoph Lameter
2008-05-20 19:14             ` Matt Mackall [this message]
2008-05-20 19:16               ` Christoph Lameter
2008-05-20 21:22                 ` Matt Mackall
2008-05-21  1:19                   ` Paul Mundt
2008-05-21  1:52                     ` Christoph Lameter
2008-05-22  4:23     ` Pekka Enberg
2008-05-20 16:29 ` Matt Mackall
2008-05-21  2:43   ` Paul Mundt
2008-05-21 14:58 ` Pekka Enberg
2008-05-21 15:06   ` Matt Mackall
2008-05-21 17:13 ` Pekka J Enberg
2008-05-21 17:27   ` Christoph Lameter
2008-05-21 19:08   ` Pekka Enberg
2008-05-21 23:43   ` Paul Mundt
2008-05-22  0:01     ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1211310896.18026.214.camel@calx \
    --to=mpm@selenic.com \
    --cc=clameter@sgi.com \
    --cc=dhowells@redhat.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).