Re: [PATCH 4/5] kmemtrace: SLUB hooks.

Steven Rostedt
2008-08-11T15:54:31Z

On Mon, 11 Aug 2008, Christoph Lameter wrote:

> Frank Ch. Eigler wrote:
> > Christoph Lameter <cl@linux-foundation.org> writes:
> >
> >> [...]
> >>> There should be no extra function calls when this is configured on but
> >>> tracing disabled. We try very hard to keep the speed of the tracer as
> >>> close to a non tracing kernel as possible when tracing is disabled.
> >> Makes sense. But then we have even more code bloat because of the
> >> tests that are inserted in all call sites of kmalloc.
> >
> > Are you talking about the tests that implement checking whether a
> > marker is active or not? Those checks are already efficient, and will
> > get more so with the "immediate values" optimization in or near the
> > tree.
>
> AFAICT: Each test also adds an out of line call to the tracing facility.
>

Frank,

Christoph is correct. He's not bringing up the issue of efficiency, but
the issue of bloat.

The marker code will be added to everyplace that calls kmalloc. Which can
be quite a lot. I'd be interested in seeing the size of the .text section
with and without this patch added and makers configure in.

-- Steve