Re: Re: Re: Re: [PATCH 9/13] memcg: lookup page cgroup (and remove pointer from struct page)

kamezawa.hiroyu
2008-09-22T17:34:46Z

>On Tue, 2008-09-23 at 00:57 +0900, kamezawa.hiroyu@jp.fujitsu.com wrote:
>> I'll add FLATMEM/SPARSEMEM support later. Could you wait for a while ?
>> Because we have lookup_page_cgroup() after this, we can do anything.
>
>OK, I'll stop harassing for the moment, and take a look at the cache. :)
>
Why I don't say "optimize this! now! more!" is where this is called is
limited now. only at charge/uncharge. This is not memmap.

charge ...the first page fault to the page
add to radix-tree
uncharge ...the last unmap aginst the page
remove from radix-tree.

I can make this faster by using charactoristics of FLATMEM and others.
(with more #ifdefs and codes.)
But would like to start from generic one because adding interface is
the first thing I have to do here.

BTW, to be honest, I don't like 2-level-table-lookup like
SPARSEMEM_EXTREME, here. A style like SPARSEMEM_VMEMMAP...using
linear virtual address map will be goal of mine.

Thanks,
-Kame