Re: [RFC][PATCH] lru_add_drain_all() don't use schedule_on_each_cpu()

Heiko Carstens
2008-10-24T19:20:32Z

On Fri, Oct 24, 2008 at 12:00:17AM +0900, KOSAKI Motohiro wrote:
> Hi Heiko,
> > This bug is caused by folloing dependencys.
> >
> > some VM place has
> > mmap_sem -> kevent_wq
> >
> > net/core/dev.c::dev_ioctl() has
> > rtnl_lock -> mmap_sem (*) almost ioctl has
> > copy_from_user() and it cause page fault.
> >
> > linkwatch_event has
> > kevent_wq -> rtnl_lock
> >
> >
> > So, I think VM subsystem shouldn't use kevent_wq because many driver
> > use ioctl and work queue combination.
> > then drivers fixing isn't easy.
> >
> > I'll make the patch soon.
>
> My box can't reproduce this issue.
> Could you please test on following patch?

Your patch seems to fix the issue. At least I don't see the warning anymore ;)

Thanks,
Heiko