Re: [RFC][PATCH] lru_add_drain_all() don't use schedule_on_each_cpu()

Peter Zijlstra
2008-11-05T09:51:44Z

On Wed, 2008-10-29 at 16:20 +0900, KOSAKI Motohiro wrote:
> > I guess we should document our newly discovered schedule_on_each_cpu()
> > problems before we forget about it and later rediscover it.
>
> Now, schedule_on_each_cpu() is only used by lru_add_drain_all().
> and smp_call_function() is better way for cross call.
>
> So I propose
> 1. lru_add_drain_all() use smp_call_function()
> 2. remove schedule_on_each_cpu()
>
>
> Thought?

At the very least that will not solve the problem on -rt where a lot of
the smp_call_function() users are converted to schedule_on_each_cpu().