From: Mel Gorman <mel@csn.ul.ie>
To: Mel Gorman <mel@csn.ul.ie>,
Linux Memory Management List <linux-mm@kvack.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Christoph Lameter <cl@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lin Ming <ming.m.lin@intel.com>,
Zhang Yanmin <yanmin_zhang@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 04/25] Check only once if the zonelist is suitable for the allocation
Date: Fri, 20 Mar 2009 10:02:51 +0000 [thread overview]
Message-ID: <1237543392-11797-5-git-send-email-mel@csn.ul.ie> (raw)
In-Reply-To: <1237543392-11797-1-git-send-email-mel@csn.ul.ie>
It is possible with __GFP_THISNODE that no zones are suitable. This
patch makes sure the check is only made once.
Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Reviewed-by: Christoph Lameter <cl@linux-foundation.org>
---
mm/page_alloc.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index dd87dad..8024abc 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1486,9 +1486,8 @@ __alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order,
if (should_fail_alloc_page(gfp_mask, order))
return NULL;
-restart:
- z = zonelist->_zonerefs; /* the list of zones suitable for gfp_mask */
-
+ /* the list of zones suitable for gfp_mask */
+ z = zonelist->_zonerefs;
if (unlikely(!z->zone)) {
/*
* Happens if we have an empty zonelist as a result of
@@ -1497,6 +1496,7 @@ restart:
return NULL;
}
+restart:
page = get_page_from_freelist(gfp_mask|__GFP_HARDWALL, nodemask, order,
zonelist, high_zoneidx, ALLOC_WMARK_LOW|ALLOC_CPUSET);
if (page)
--
1.5.6.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-03-20 15:29 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 10:02 [PATCH 00/25] Cleanup and optimise the page allocator V5 Mel Gorman
2009-03-20 10:02 ` [PATCH 01/25] Replace __alloc_pages_internal() with __alloc_pages_nodemask() Mel Gorman
2009-03-20 10:02 ` [PATCH 02/25] Do not sanity check order in the fast path Mel Gorman
2009-03-20 10:02 ` [PATCH 03/25] Do not check NUMA node ID when the caller knows the node is valid Mel Gorman
2009-03-20 10:02 ` Mel Gorman [this message]
2009-03-20 10:02 ` [PATCH 05/25] Break up the allocator entry point into fast and slow paths Mel Gorman
2009-03-20 10:02 ` [PATCH 06/25] Move check for disabled anti-fragmentation out of fastpath Mel Gorman
2009-03-20 10:02 ` [PATCH 07/25] Check in advance if the zonelist needs additional filtering Mel Gorman
2009-03-20 15:04 ` Christoph Lameter
2009-03-20 10:02 ` [PATCH 08/25] Calculate the preferred zone for allocation only once Mel Gorman
2009-03-20 15:06 ` Christoph Lameter
2009-03-20 15:29 ` Mel Gorman
2009-03-20 10:02 ` [PATCH 09/25] Calculate the migratetype " Mel Gorman
2009-03-20 15:08 ` Christoph Lameter
2009-03-20 10:02 ` [PATCH 10/25] Calculate the alloc_flags " Mel Gorman
2009-03-20 10:02 ` [PATCH 11/25] Calculate the cold parameter " Mel Gorman
2009-03-20 15:09 ` Christoph Lameter
2009-04-21 15:13 ` Mel Gorman
2009-04-21 15:25 ` Christoph Lameter
2009-04-21 15:47 ` Mel Gorman
2009-03-20 10:02 ` [PATCH 12/25] Remove a branch by assuming __GFP_HIGH == ALLOC_HIGH Mel Gorman
2009-03-20 10:03 ` [PATCH 13/25] Inline __rmqueue_smallest() Mel Gorman
2009-03-20 10:03 ` [PATCH 14/25] Inline buffered_rmqueue() Mel Gorman
2009-03-20 10:03 ` [PATCH 15/25] Inline __rmqueue_fallback() Mel Gorman
2009-03-20 10:03 ` [PATCH 16/25] Save text by reducing call sites of __rmqueue() Mel Gorman
2009-03-20 10:03 ` [PATCH 17/25] Do not call get_pageblock_migratetype() more than necessary Mel Gorman
2009-03-20 10:03 ` [PATCH 18/25] Do not disable interrupts in free_page_mlock() Mel Gorman
2009-03-20 10:03 ` [PATCH 19/25] Do not setup zonelist cache when there is only one node Mel Gorman
2009-03-20 10:03 ` [PATCH 20/25] Do not check for compound pages during the page allocator sanity checks Mel Gorman
2009-03-20 10:03 ` [PATCH 21/25] Use allocation flags as an index to the zone watermark Mel Gorman
2009-03-20 10:03 ` [PATCH 22/25] Update NR_FREE_PAGES only as necessary Mel Gorman
2009-03-20 10:03 ` [PATCH 23/25] Get the pageblock migratetype without disabling interrupts Mel Gorman
2009-03-20 10:03 ` [PATCH 24/25] Re-sort GFP flags and fix whitespace alignment for easier reading Mel Gorman
2009-03-20 10:03 ` [PATCH 25/25] Use a pre-calculated value instead of num_online_nodes() in fast paths Mel Gorman
2009-03-20 15:00 ` [PATCH 00/25] Cleanup and optimise the page allocator V5 Christoph Lameter
2009-03-20 15:37 ` Mel Gorman
2009-03-20 16:04 ` Christoph Lameter
2009-03-20 16:41 ` Mel Gorman
2009-03-20 16:07 ` Christoph Lameter
2009-03-20 16:27 ` Mel Gorman
2009-03-20 19:43 ` Christoph Lameter
2009-03-23 11:52 ` Mel Gorman
2009-03-23 13:30 ` Christoph Lameter
2009-03-23 14:59 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2009-04-20 22:19 [PATCH 00/25] Cleanup and optimise the page allocator V6 Mel Gorman
2009-04-20 22:19 ` [PATCH 04/25] Check only once if the zonelist is suitable for the allocation Mel Gorman
2009-04-21 3:03 ` KOSAKI Motohiro
2009-04-21 7:09 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237543392-11797-5-git-send-email-mel@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ming.m.lin@intel.com \
--cc=npiggin@suse.de \
--cc=peterz@infradead.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).