Re: [PATCH 01/25] Replace __alloc_pages_internal() with __alloc_pages_nodemask()

KOSAKI Motohiro
2009-04-21T01:43:42Z

> include/linux/gfp.h | 12 ++----------
> mm/page_alloc.c | 4 ++--
> 2 files changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/include/linux/gfp.h b/include/linux/gfp.h
> index 0bbc15f..556c840 100644
> --- a/include/linux/gfp.h
> +++ b/include/linux/gfp.h
> @@ -169,24 +169,16 @@ static inline void arch_alloc_page(struct page *page, int order) { }
> #endif
>
> struct page *
> -__alloc_pages_internal(gfp_t gfp_mask, unsigned int order,
> +__alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order,
> struct zonelist *zonelist, nodemask_t *nodemask);
>
> static inline struct page *
> __alloc_pages(gfp_t gfp_mask, unsigned int order,
> struct zonelist *zonelist)
> {
> - return __alloc_pages_internal(gfp_mask, order, zonelist, NULL);
> + return __alloc_pages_nodemask(gfp_mask, order, zonelist, NULL);
> }
>
> -static inline struct page *
> -__alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order,
> - struct zonelist *zonelist, nodemask_t *nodemask)
> -{
> - return __alloc_pages_internal(gfp_mask, order, zonelist, nodemask);
> -}
> -
> -
> static inline struct page *alloc_pages_node(int nid, gfp_t gfp_mask,
> unsigned int order)
> {
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index e4ea469..dcc4f05 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1462,7 +1462,7 @@ try_next_zone:
> * This is the 'heart' of the zoned buddy allocator.
> */
> struct page *
> -__alloc_pages_internal(gfp_t gfp_mask, unsigned int order,
> +__alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order,
> struct zonelist *zonelist, nodemask_t *nodemask)
> {

sorry, late review.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>