Re: [PATCH 16/25] Save text by reducing call sites of __rmqueue()

KOSAKI Motohiro
2009-04-21T10:47:00Z

> } else {
> - spin_lock_irqsave(&zone->lock, flags);
> - page = __rmqueue(zone, order, migratetype);
> - spin_unlock(&zone->lock);
> - if (!page)
> + LIST_HEAD(list);
> + local_irq_save(flags);
> +
> + /* Calling __rmqueue would bloat text, hence this */
> + if (!rmqueue_bulk(zone, order, 1, &list, migratetype))
> goto failed;
> + page = list_entry(list.next, struct page, lru);
> + list_del(&page->lru);
> }

looks good
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>