Re: [PATCH 05/25] Break up the allocator entry point into fast and slow paths

Mel Gorman
2009-04-21T09:29:52Z

On Tue, Apr 21, 2009 at 10:13:04AM +0300, Pekka Enberg wrote:
> Hi!
>
> On Tue, 2009-04-21 at 15:35 +0900, KOSAKI Motohiro wrote:
> > > The core of the page allocator is one giant function which allocates memory
> > > on the stack and makes calculations that may not be needed for every
> > > allocation. This patch breaks up the allocator path into fast and slow
> > > paths for clarity. Note the slow paths are still inlined but the entry is
> > > marked unlikely. If they were not inlined, it actally increases text size
> > > to generate the as there is only one call site.
> >
> > hmm..
> >
> > this patch have few behavior change.
> > please separate big cleanup patch and behavior patch.
> >
> > I hope to make this patch non functional change. I'm not sure about these
> > are your intentional change or not. it cause harder reviewing...
>
> Agreed, splitting this patch into smaller chunks would make it easier to review.
>

Chunking this doesn't make it easier to review. As it is, it's possible
to go through the old path once and compare it to the new path. I had
this split out at one time, but it meant comparing old and new paths
multiple times instead of once.

However, there were functional changes in here and they needed to be
taken out.

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab