Re: [PATCH 12/25] Remove a branch by assuming __GFP_HIGH == ALLOC_HIGH

Mel Gorman
2009-04-21T10:43:17Z

On Tue, Apr 21, 2009 at 07:31:23PM +0900, KOSAKI Motohiro wrote:
> > > @@ -1639,8 +1639,8 @@ gfp_to_alloc_flags(gfp_t gfp_mask)
> > > * policy or is asking for __GFP_HIGH memory. GFP_ATOMIC requests will
> > > * set both ALLOC_HARDER (!wait) and ALLOC_HIGH (__GFP_HIGH).
> > > */
> > > - if (gfp_mask & __GFP_HIGH)
> > > - alloc_flags |= ALLOC_HIGH;
> > > + VM_BUG_ON(__GFP_HIGH != ALLOC_HIGH);
>
> Oops, I forgot said one comment.
> BUILD_BUG_ON() is better?
>

Much better. Thanks

>
> > > + alloc_flags |= (gfp_mask & __GFP_HIGH);
> > >
> > > if (!wait) {
> > > alloc_flags |= ALLOC_HARDER;
> >
> > Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> >
> >
> >
>
>
>

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab