From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Christoph Lameter <cl@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lin Ming <ming.m.lin@intel.com>,
Zhang Yanmin <yanmin_zhang@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 02/22] Do not sanity check order in the fast path
Date: Thu, 23 Apr 2009 12:26:24 -0700 [thread overview]
Message-ID: <1240514784.10627.171.camel@nimitz> (raw)
In-Reply-To: <1240450447.10627.119.camel@nimitz>
On Wed, 2009-04-22 at 18:34 -0700, Dave Hansen wrote:
> I'll also go and see what the actual .text size
> changes are from this patch both for alloc_pages() and
> alloc_pages_node() separately to make sure what we're dealing with
> here. Does this check even *exist* in the optimized code very
> often?
While this isn't definitive by any means, I did get some interesting
results. Pulling the check out of alloc_pages() had no effect at *all*
on text size because I'm trying with CONFIG_NUMA=n.
$ size i386-T41-laptop.{0,1}/vmlinux
text data bss dec hex filename
4348625 286560 860160 5495345 53da31 i386-T41-laptop.0/vmlinux
4348625 286560 860160 5495345 53da31 i386-T41-laptop.1/vmlinux
We get a slightly different when pulling the check out of
alloc_pages_node():
$ size i386-T41-laptop.{1,2}/vmlinux
text data bss dec hex filename
4348625 286560 860160 5495345 53da31 i386-T41-laptop.1/vmlinux
4348601 286560 860160 5495321 53da19 i386-T41-laptop.2/vmlinux
$ bloat-o-meter i386-T41-laptop.1/vmlinux i386-T41-laptop.2/vmlinux
add/remove: 0/0 grow/shrink: 9/7 up/down: 78/-107 (-29)
function old new delta
__get_user_pages 717 751 +34
st_read 1936 1944 +8
shmem_truncate_range 1660 1667 +7
pci_create_slot 410 417 +7
sg_build_indirect 449 455 +6
n_tty_read 1336 1342 +6
find_vma_prepare 103 108 +5
as_update_iohist 617 621 +4
ntfs_readdir 3426 3427 +1
enlarge_buffer 343 341 -2
__get_free_pages 36 33 -3
dma_generic_alloc_coherent 207 202 -5
mempool_alloc_pages 33 17 -16
futex_lock_pi 2120 2104 -16
kallsyms_lookup_name 102 82 -20
cache_alloc_refill 1171 1126 -45
I'm going to retry this with a NUMA config.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-04-23 19:26 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 13:53 [PATCH 00/22] Cleanup and optimise the page allocator V7 Mel Gorman
2009-04-22 13:53 ` [PATCH 01/22] Replace __alloc_pages_internal() with __alloc_pages_nodemask() Mel Gorman
2009-04-22 13:53 ` [PATCH 02/22] Do not sanity check order in the fast path Mel Gorman
2009-04-22 16:13 ` Dave Hansen
2009-04-22 17:11 ` Mel Gorman
2009-04-22 17:30 ` Dave Hansen
2009-04-23 0:13 ` Mel Gorman
2009-04-23 1:34 ` Dave Hansen
2009-04-23 9:58 ` Mel Gorman
2009-04-23 17:36 ` Dave Hansen
2009-04-24 2:57 ` KOSAKI Motohiro
2009-04-24 10:34 ` Mel Gorman
2009-04-24 14:16 ` Dave Hansen
2009-04-23 19:26 ` Dave Hansen [this message]
2009-04-23 19:45 ` Dave Hansen
2009-04-24 9:21 ` Mel Gorman
2009-04-24 14:25 ` Dave Hansen
2009-04-22 20:11 ` David Rientjes
2009-04-22 20:20 ` Christoph Lameter
2009-04-23 7:44 ` Pekka Enberg
2009-04-23 22:44 ` Andrew Morton
2009-04-22 13:53 ` [PATCH 03/22] Do not check NUMA node ID when the caller knows the node is valid Mel Gorman
2009-04-22 13:53 ` [PATCH 04/22] Check only once if the zonelist is suitable for the allocation Mel Gorman
2009-04-22 13:53 ` [PATCH 05/22] Break up the allocator entry point into fast and slow paths Mel Gorman
2009-04-22 13:53 ` [PATCH 06/22] Move check for disabled anti-fragmentation out of fastpath Mel Gorman
2009-04-22 13:53 ` [PATCH 07/22] Calculate the preferred zone for allocation only once Mel Gorman
2009-04-23 22:48 ` Andrew Morton
2009-04-22 13:53 ` [PATCH 08/22] Calculate the migratetype " Mel Gorman
2009-04-22 13:53 ` [PATCH 09/22] Calculate the alloc_flags " Mel Gorman
2009-04-23 22:52 ` Andrew Morton
2009-04-24 10:47 ` Mel Gorman
2009-04-24 17:51 ` Andrew Morton
2009-04-22 13:53 ` [PATCH 10/22] Remove a branch by assuming __GFP_HIGH == ALLOC_HIGH Mel Gorman
2009-04-22 13:53 ` [PATCH 11/22] Inline __rmqueue_smallest() Mel Gorman
2009-04-22 13:53 ` [PATCH 12/22] Inline buffered_rmqueue() Mel Gorman
2009-04-22 13:53 ` [PATCH 13/22] Inline __rmqueue_fallback() Mel Gorman
2009-04-22 13:53 ` [PATCH 14/22] Do not call get_pageblock_migratetype() more than necessary Mel Gorman
2009-04-22 13:53 ` [PATCH 15/22] Do not disable interrupts in free_page_mlock() Mel Gorman
2009-04-23 22:59 ` Andrew Morton
2009-04-24 0:07 ` KOSAKI Motohiro
2009-04-24 0:33 ` KOSAKI Motohiro
2009-04-24 11:33 ` Mel Gorman
2009-04-24 11:52 ` Lee Schermerhorn
2009-04-24 11:18 ` Mel Gorman
2009-04-22 13:53 ` [PATCH 16/22] Do not setup zonelist cache when there is only one node Mel Gorman
2009-04-22 20:24 ` David Rientjes
2009-04-22 20:32 ` Lee Schermerhorn
2009-04-22 20:34 ` David Rientjes
2009-04-23 0:11 ` KOSAKI Motohiro
2009-04-23 0:19 ` Mel Gorman
2009-04-22 13:53 ` [PATCH 17/22] Do not check for compound pages during the page allocator sanity checks Mel Gorman
2009-04-22 13:53 ` [PATCH 18/22] Use allocation flags as an index to the zone watermark Mel Gorman
2009-04-22 17:11 ` Dave Hansen
2009-04-22 17:14 ` Mel Gorman
2009-04-22 17:47 ` Dave Hansen
2009-04-23 0:27 ` KOSAKI Motohiro
2009-04-23 10:03 ` Mel Gorman
2009-04-24 6:41 ` KOSAKI Motohiro
2009-04-22 20:06 ` David Rientjes
2009-04-23 0:29 ` Mel Gorman
2009-04-27 17:00 ` [RFC] Replace the watermark-related union in struct zone with a watermark[] array Mel Gorman
2009-04-27 20:48 ` David Rientjes
2009-04-27 20:54 ` Mel Gorman
2009-04-27 20:51 ` Christoph Lameter
2009-04-27 21:04 ` David Rientjes
2009-04-30 13:35 ` Mel Gorman
2009-04-30 13:48 ` Dave Hansen
2009-05-12 14:13 ` [RFC] Replace the watermark-related union in struct zone with a watermark[] array V2 Mel Gorman
2009-05-12 15:05 ` [RFC] Replace the watermark-related union in struct zone with awatermark[] " Dave Hansen
2009-05-13 8:31 ` [RFC] Replace the watermark-related union in struct zone with a watermark[] " KOSAKI Motohiro
2009-04-22 13:53 ` [PATCH 19/22] Update NR_FREE_PAGES only as necessary Mel Gorman
2009-04-23 23:06 ` Andrew Morton
2009-04-23 23:04 ` Christoph Lameter
2009-04-24 13:06 ` Mel Gorman
2009-04-22 13:53 ` [PATCH 20/22] Get the pageblock migratetype without disabling interrupts Mel Gorman
2009-04-22 13:53 ` [PATCH 21/22] Use a pre-calculated value instead of num_online_nodes() in fast paths Mel Gorman
2009-04-22 23:04 ` David Rientjes
2009-04-23 0:44 ` Mel Gorman
2009-04-23 19:29 ` David Rientjes
2009-04-24 13:31 ` [PATCH] Do not override definition of node_set_online() with macro Mel Gorman
2009-04-22 13:53 ` [PATCH 22/22] slab: Use nr_online_nodes to check for a NUMA platform Mel Gorman
2009-04-22 14:37 ` Pekka Enberg
2009-04-27 7:58 ` [PATCH 00/22] Cleanup and optimise the page allocator V7 Zhang, Yanmin
2009-04-27 14:38 ` Mel Gorman
2009-04-28 1:59 ` Zhang, Yanmin
2009-04-28 10:27 ` Mel Gorman
2009-04-28 10:31 ` [PATCH] Properly account for freed pages in free_pages_bulk() and when allocating high-order pages in buffered_rmqueue() Mel Gorman
2009-04-28 16:37 ` Christoph Lameter
2009-04-28 16:51 ` Mel Gorman
2009-04-28 17:15 ` Hugh Dickins
2009-04-28 18:07 ` [PATCH] Properly account for freed pages in free_pages_bulk() and when allocating high-order pages in buffered_rmqueue() V2 Mel Gorman
2009-04-28 18:25 ` Hugh Dickins
2009-04-28 18:36 ` [PATCH] Properly account for freed pages in free_pages_bulk() and when allocating high-order pages in buffered_rmqueue() Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240514784.10627.171.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=ming.m.lin@intel.com \
--cc=npiggin@suse.de \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).