From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Nick Piggin <npiggin@suse.de>
Cc: stable@kernel.org, linux-mm@kvack.org,
Matt Mackall <mpm@selenic.com>, Christoph Lameter <cl@linux.com>,
akpm@linux-foundation.org
Subject: Re: [patch 1/3] mm: SLUB fix reclaim_state
Date: Thu, 07 May 2009 11:50:40 +0300 [thread overview]
Message-ID: <1241686240.17846.19.camel@penberg-laptop> (raw)
In-Reply-To: <20090506134236.GA3012@wotan.suse.de>
Hi Nick,
On Wed, 2009-05-06 at 15:42 +0200, Nick Piggin wrote:
> > I have applied the patch series. I see you have cc'd stable so I assume
> > you want this in 2.6.30, right? This seems like a rather serious bug but
>
> Thanks. I think it makes sense to into 2.6.30. Also probably all active
> .stable kernels.
>
>
> > I wonder why we've gotten away with it for so long? Is there a test
> > program or a known workload that breaks without this?
>
> Well... it isn't doing what reclaim code wants, and it is differing
> behaviour between SLAB and SL?B, so I think it is fairly safe to
> merge these now.
>
> It doesn't look like too much *significant* changes to heuristics, but
> things will get skewed here and there.
Yeah, that's my thinking too. Oh, well, I'll forward it to Linus' way
and let the stable guys decide whether they want to take it or not.
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-07 8:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090505091343.706910164@suse.de>
2009-05-05 9:13 ` [patch 1/3] mm: SLUB fix reclaim_state npiggin
2009-05-05 13:46 ` Christoph Lameter
2009-05-06 7:20 ` Pekka Enberg
2009-05-06 13:29 ` Christoph Lameter
2009-05-06 13:42 ` Nick Piggin
2009-05-07 8:50 ` Pekka Enberg [this message]
2009-05-06 16:02 ` Johannes Weiner
2009-05-06 16:34 ` Matt Mackall
2009-05-05 9:13 ` [patch 2/3] mm: SLOB " npiggin
2009-05-05 13:47 ` Christoph Lameter
2009-05-05 16:47 ` Matt Mackall
2009-05-05 9:13 ` [patch 3/3] mm: SLQB " npiggin
2009-05-05 13:47 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241686240.17846.19.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=npiggin@suse.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).