Re: [PATCH 04/23] vfs: Introduce infrastructure for revoking a file

Eric W. Biederman
2009-06-03T15:39:34Z

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Tue, 2 Jun 2009, Nick Piggin wrote:
>>
>> Why is it called hotplug? Does it have anything to do with hardware?
>> Because every concurrently changed software data structure in the
>> kernel can be "hot"-modified, right?
>>
>> Wouldn't file_revoke_lock be more appropriate?
>
> I agree, "hotplug" just sounds crazy. It's "open" and "revoke", not
> "plug" and "unplug".

I guess this shows my bias in triggering this code path from pci
hotunplug. Instead of with some system call.

I'm not married to the name. I wanted file_lock but that is already
used, and I did call the method revoke.

The only place where hotplug gives a useful hint is that it makes it
clear we really are disconnecting the file descriptor from what lies
below it. We can't do some weird thing like keep the underlying object.
Because the underlying object is gone.

Eric