Re: [patch] procfs: provide stack information for threads

[Stefani Seibold <stefani@seibold.net>]

Am Donnerstag, den 04.06.2009, 04:37 -0700 schrieb Andrew Morton:
> On Thu, 04 Jun 2009 13:23:48 +0200 Stefani Seibold <stefani@seibold.net> wrote:
> >  - slime done
> 
> What's "slime"?
> 

Sorry, that was a typo, should be "slim down".

> > +	for (i = vma->vm_start; i+PAGE_SIZE <= stkpage; i += PAGE_SIZE) {
> > +
> > +		page = follow_page(vma, i, 0);
> > +
> > +		if (!IS_ERR(page) && page)
> 
> Shouldn't this be !page?
> 

No, this is correct... I walk through the top of vma to the first mapped
page, this is the high water mark of the stack.

> > +					unsigned long stack_start;
> > +
> > +					stack_start =
> > +						((struct proc_maps_private *)
> > +						m->private)->task->stack_start;
> 
> I'd suggested a clearer/cleaner way of implementing this.
> 

Sorry, i can not see a problem here. In your last posting you wrote
thats okay! And i have no idea how to make this expression
clearer/cleaner.

> > Signed-off-by: Stefani Seibold <stefani@seibold.net>
> 
> This should be positioned at the end of the changelog, ahead of the
> patch itself.
> 

Next time i will do this, okay?


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>