Re: [patch 2/2] procfs: provide stack information for threads V0.8

[Stefani Seibold <stefani@seibold.net>]

Am Montag, den 15.06.2009, 15:01 -0700 schrieb Andrew Morton:
> > ...
> >
> > --- linux-2.6.30.orig/include/linux/sched.h	2009-06-04 09:29:47.000000000 +0200
> > +++ linux-2.6.30/include/linux/sched.h	2009-06-04 09:32:35.000000000 +0200
> > @@ -1429,6 +1429,7 @@
> >  	/* state flags for use by tracers */
> >  	unsigned long trace;
> >  #endif
> > +	unsigned long stack_start;
> >  };
> >  
> 
> A `stack_start' in the task_struct.  This is a bit confusing - we
> already have a `void *stack' in there.  Perhaps this should be named
> user_stack_start or something?
> 
> 
IMHO i think the void *stack is also a to general name, it should be
name kernel_stack or thread_info.

In real we have two stack, so the name user_stack and kernel_stack would
be my favor.

I have examined the source and and task_struct void *stack would be used
in about 10 files.
 


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>