From: Joe Perches <joe@perches.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] kmemleak: use pr_fmt
Date: Fri, 19 Jun 2009 12:49:42 -0700 [thread overview]
Message-ID: <1245440992.6201.17.camel@Joe-Laptop> (raw)
In-Reply-To: <1245405220.12653.25.camel@pc1117.cambridge.arm.com>
On Fri, 2009-06-19 at 10:53 +0100, Catalin Marinas wrote:
> Thanks for the patch. It missed one pr_info case (actually invoked via
> the pr_helper macro).
This change will affect the seq_printf uses.
Some think the seq output should be immutable.
Perhaps that's important to you or others.
An option is to change the print_helper
pr_info to a printk(KERN_INFO and not change
any uses of print_helper
#define print_helper(seq, x...) do { \
struct seq_file *s = (seq); \
if (s) \
seq_printf(s, x); \
else \
printk(KERN_INFO x); \
} while (0)
> > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > +
> ^ - empty space at the end of the line (git told me about it)
Thanks for letting me know. I'll fix my tools.
Joe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-20 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 16:08 [PATCH] kmemleak: use pr_fmt Joe Perches
2009-06-19 9:53 ` Catalin Marinas
2009-06-19 19:49 ` Joe Perches [this message]
2009-06-22 9:55 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245440992.6201.17.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).