From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id EFF8C6B0085 for ; Fri, 19 Jun 2009 19:49:01 -0400 (EDT) Subject: Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending From: Benjamin Herrenschmidt In-Reply-To: <20090619232336.GA2442@elf.ucw.cz> References: <20090619145913.GA1389@ucw.cz> <1245450449.16880.10.camel@pasglop> <20090619232336.GA2442@elf.ucw.cz> Content-Type: text/plain Date: Sat, 20 Jun 2009 09:50:09 +1000 Message-Id: <1245455409.16880.15.camel@pasglop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Pavel Machek Cc: Pekka J Enberg , linux-mm@kvack.org, linux-kernel@vger.kernel.org, mingo@elte.hu, npiggin@suse.de, akpm@linux-foundation.org, cl@linux-foundation.org, torvalds@linux-foundation.org List-ID: On Sat, 2009-06-20 at 01:23 +0200, Pavel Machek wrote: > > No. First, code that assumes GFP_KERNEL don't fail is stupid. Any > > allocation should always be assumed to potentially fail. > > Stupid, yes. Uncommon? Not sure. A lot less than it used to be, we've been fixing those by the truckload over the past few years. But again, if allocations start failing that early at boot, you are likely to be doomed anyway. Still, better to do proper error handling, and I think we -mostly- do (ok, not -always-). > > Then, if you start failing allocations at boot time, then you aren't > > going anywhere are you ? > > Exactly. So boot code should have access to all the memory, right? > Setting some aside for GFP_ATOMIC does not make sense in that context. I'm not certain what you mean here. If you're going to hit the atomic reserve that early, you aren't going anywhere neither :-) Is there any real problem you are trying to solve here or is it all just academic ? Cheers, Ben. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org