Re: [PATCH] kmemleak: use pr_fmt

[Catalin Marinas <catalin.marinas@arm.com>]

On Fri, 2009-06-19 at 12:49 -0700, Joe Perches wrote:
> On Fri, 2009-06-19 at 10:53 +0100, Catalin Marinas wrote:
> > Thanks for the patch. It missed one pr_info case (actually invoked via
> > the pr_helper macro).
> 
> This change will affect the seq_printf uses.
> Some think the seq output should be immutable.
> Perhaps that's important to you or others.

My point was that with your patch, the kmemleak kernel messages with
pr_info were something like:

kmemleak: kmemleak: unreferenced object ...
kmemleak:   comm ...
kmemleak:   backtrace:

After dropping "kmemleak: " in the print_helper() call, kernel messages
become (which I find nicer):

kmemleak: unreferenced object ...
kmemleak:   comm ...
kmemleak:   backtrace:

For the seq_printf() we really don't need the "kmemleak: " prefix since
you read a kmemleak-specific file anyway. With my modification, the seq
output becomes:

unreferenced object ...
  comm ...
  backtrace:

i.e. without the "kmemleak: " prefix on the "unreferenced ..." line.

-- 
Catalin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>