Re: [RFC PATCH 2/3] kmemleak: Add callbacks to the bootmem allocator

Johannes Weiner
2009-07-08T11:38:55Z

On Wed, Jul 08, 2009 at 10:43:51AM +0100, Catalin Marinas wrote:

> kmemleak: Add callbacks to the bootmem allocator
>
> From: Catalin Marinas <catalin.marinas@arm.com>
>
> This patch adds kmemleak_alloc/free callbacks to the bootmem allocator.
> This would allow scanning of such blocks and help avoiding a whole class
> of false positives and more kmemleak annotations.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Pekka Enberg <penberg@cs.helsinki.fi>

Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>

> ---
> mm/bootmem.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/mm/bootmem.c b/mm/bootmem.c
> index d2a9ce9..90f3ed0 100644
> --- a/mm/bootmem.c
> +++ b/mm/bootmem.c
> @@ -335,6 +335,8 @@ void __init free_bootmem_node(pg_data_t *pgdat, unsigned long physaddr,
> {
> unsigned long start, end;
>
> + kmemleak_free_part(__va(physaddr), size);
> +
> start = PFN_UP(physaddr);
> end = PFN_DOWN(physaddr + size);
>
> @@ -354,6 +356,8 @@ void __init free_bootmem(unsigned long addr, unsigned long size)
> {
> unsigned long start, end;
>
> + kmemleak_free_part(__va(addr), size);
> +
> start = PFN_UP(addr);
> end = PFN_DOWN(addr + size);
>
> @@ -516,6 +520,7 @@ find_block:
> region = phys_to_virt(PFN_PHYS(bdata->node_min_pfn) +
> start_off);
> memset(region, 0, size);
> + kmemleak_alloc(region, size, 1, 0);
> return region;
> }