linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/memory-failure: remove CONFIG_UNEVICTABLE_LRU config option
@ 2009-08-28 19:09 Vincent Li
  2009-08-28 22:40 ` Minchan Kim
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Vincent Li @ 2009-08-28 19:09 UTC (permalink / raw)
  To: linux-mm
  Cc: KOSAKI Motohiro, Andi Kleen, Wu Fengguang, Andrew Morton,
	Vincent Li

Commit 683776596 (remove CONFIG_UNEVICTABLE_LRU config option) removed this config option.
Removed it from mm/memory-failure too.

Signed-off-by: Vincent Li <macli@brc.ubc.ca>
---
 mm/memory-failure.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index f78d9fc..2bc4c50 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -587,10 +587,8 @@ static struct page_state {
 	{ sc|dirty,	sc|dirty,	"swapcache",	me_swapcache_dirty },
 	{ sc|dirty,	sc,		"swapcache",	me_swapcache_clean },
 
-#ifdef CONFIG_UNEVICTABLE_LRU
 	{ unevict|dirty, unevict|dirty,	"unevictable LRU", me_pagecache_dirty},
 	{ unevict,	unevict,	"unevictable LRU", me_pagecache_clean},
-#endif
 
 #ifdef CONFIG_HAVE_MLOCKED_PAGE_BIT
 	{ mlock|dirty,	mlock|dirty,	"mlocked LRU",	me_pagecache_dirty },
-- 
1.6.0.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm/memory-failure: remove CONFIG_UNEVICTABLE_LRU config option
  2009-08-28 19:09 [PATCH] mm/memory-failure: remove CONFIG_UNEVICTABLE_LRU config option Vincent Li
@ 2009-08-28 22:40 ` Minchan Kim
  2009-08-29  4:54 ` KOSAKI Motohiro
  2009-08-29  9:46 ` Wu Fengguang
  2 siblings, 0 replies; 4+ messages in thread
From: Minchan Kim @ 2009-08-28 22:40 UTC (permalink / raw)
  To: Vincent Li
  Cc: linux-mm, KOSAKI Motohiro, Andi Kleen, Wu Fengguang,
	Andrew Morton

On Sat, Aug 29, 2009 at 4:09 AM, Vincent Li<macli@brc.ubc.ca> wrote:
> Commit 683776596 (remove CONFIG_UNEVICTABLE_LRU config option) removed this config option.
> Removed it from mm/memory-failure too.
>
> Signed-off-by: Vincent Li <macli@brc.ubc.ca>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>

Nice catch.


-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm/memory-failure: remove CONFIG_UNEVICTABLE_LRU config option
  2009-08-28 19:09 [PATCH] mm/memory-failure: remove CONFIG_UNEVICTABLE_LRU config option Vincent Li
  2009-08-28 22:40 ` Minchan Kim
@ 2009-08-29  4:54 ` KOSAKI Motohiro
  2009-08-29  9:46 ` Wu Fengguang
  2 siblings, 0 replies; 4+ messages in thread
From: KOSAKI Motohiro @ 2009-08-29  4:54 UTC (permalink / raw)
  To: Vincent Li; +Cc: linux-mm, Andi Kleen, Wu Fengguang, Andrew Morton

2009/8/29 Vincent Li <macli@brc.ubc.ca>:
> Commit 683776596 (remove CONFIG_UNEVICTABLE_LRU config option) removed this config option.
> Removed it from mm/memory-failure too.
>
> Signed-off-by: Vincent Li <macli@brc.ubc.ca>
> ---
>  mm/memory-failure.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index f78d9fc..2bc4c50 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -587,10 +587,8 @@ static struct page_state {
>        { sc|dirty,     sc|dirty,       "swapcache",    me_swapcache_dirty },
>        { sc|dirty,     sc,             "swapcache",    me_swapcache_clean },
>
> -#ifdef CONFIG_UNEVICTABLE_LRU
>        { unevict|dirty, unevict|dirty, "unevictable LRU", me_pagecache_dirty},
>        { unevict,      unevict,        "unevictable LRU", me_pagecache_clean},
> -#endif

Looks good to me.
     Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm/memory-failure: remove CONFIG_UNEVICTABLE_LRU config option
  2009-08-28 19:09 [PATCH] mm/memory-failure: remove CONFIG_UNEVICTABLE_LRU config option Vincent Li
  2009-08-28 22:40 ` Minchan Kim
  2009-08-29  4:54 ` KOSAKI Motohiro
@ 2009-08-29  9:46 ` Wu Fengguang
  2 siblings, 0 replies; 4+ messages in thread
From: Wu Fengguang @ 2009-08-29  9:46 UTC (permalink / raw)
  To: Vincent Li; +Cc: linux-mm@kvack.org, KOSAKI Motohiro, Andi Kleen, Andrew Morton

On Sat, Aug 29, 2009 at 03:09:13AM +0800, Vincent Li wrote:
> Commit 683776596 (remove CONFIG_UNEVICTABLE_LRU config option) removed this config option.
> Removed it from mm/memory-failure too.

Good catch!

Acked-by: Wu Fengguang <fengguang.wu@intel.com>

> Signed-off-by: Vincent Li <macli@brc.ubc.ca>
> ---
>  mm/memory-failure.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index f78d9fc..2bc4c50 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -587,10 +587,8 @@ static struct page_state {
>  	{ sc|dirty,	sc|dirty,	"swapcache",	me_swapcache_dirty },
>  	{ sc|dirty,	sc,		"swapcache",	me_swapcache_clean },
>  
> -#ifdef CONFIG_UNEVICTABLE_LRU
>  	{ unevict|dirty, unevict|dirty,	"unevictable LRU", me_pagecache_dirty},
>  	{ unevict,	unevict,	"unevictable LRU", me_pagecache_clean},
> -#endif
>  
>  #ifdef CONFIG_HAVE_MLOCKED_PAGE_BIT
>  	{ mlock|dirty,	mlock|dirty,	"mlocked LRU",	me_pagecache_dirty },
> -- 
> 1.6.0.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-08-29  9:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-28 19:09 [PATCH] mm/memory-failure: remove CONFIG_UNEVICTABLE_LRU config option Vincent Li
2009-08-28 22:40 ` Minchan Kim
2009-08-29  4:54 ` KOSAKI Motohiro
2009-08-29  9:46 ` Wu Fengguang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).