From: Mel Gorman <mel@csn.ul.ie>
To: Andrew Morton <akpm@linux-foundation.org>, stable <stable@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
David Miller <davem@davemloft.net>, Frans Pop <elendil@planet.nl>,
reinette chatre <reinette.chatre@intel.com>,
Kalle Valo <kalle.valo@iki.fi>,
"John W. Linville" <linville@tuxdriver.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Karol Lewandowski <karol.k.lewandowski@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"linux-mm@kvack.org\"" <linux-mm@kvack.org>,
Mel Gorman <mel@csn.ul.ie>
Subject: [PATCH 2/2] page allocator: Direct reclaim should always obey watermarks
Date: Fri, 16 Oct 2009 11:37:26 +0100 [thread overview]
Message-ID: <1255689446-3858-3-git-send-email-mel@csn.ul.ie> (raw)
In-Reply-To: <1255689446-3858-1-git-send-email-mel@csn.ul.ie>
ALLOC_NO_WATERMARKS should be cleared when trying to allocate from the
free-lists after a direct reclaim. If it's not, __GFP_NOFAIL allocations
from a process that is exiting can ignore watermarks. __GFP_NOFAIL is not
often used but the journal layer is one of those places. This is suspected of
causing an increase in the number of GFP_ATOMIC allocation failures reported.
Signed-off-by: Mel Gorman <mel@csn.ul.ie>
---
mm/page_alloc.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index dfa4362..a3e5fed 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1860,7 +1860,8 @@ rebalance:
page = __alloc_pages_direct_reclaim(gfp_mask, order,
zonelist, high_zoneidx,
nodemask,
- alloc_flags, preferred_zone,
+ alloc_flags & ~ALLOC_NO_WATERMARKS,
+ preferred_zone,
migratetype, &did_some_progress);
if (page)
goto got_pg;
--
1.6.3.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-10-16 10:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 10:37 [PATCH 0/2] Reduce number of GFP_ATOMIC allocation failures Mel Gorman
2009-10-16 10:37 ` [PATCH 1/2] page allocator: Always wake kswapd when restarting an allocation attempt after direct reclaim failed Mel Gorman
2009-10-16 10:52 ` Pekka Enberg
2009-10-19 7:40 ` Christoph Lameter
2009-10-16 10:37 ` Mel Gorman [this message]
2009-10-16 19:07 ` [PATCH 2/2] page allocator: Direct reclaim should always obey watermarks David Rientjes
2009-10-16 22:32 ` Mel Gorman
2009-10-16 23:28 ` Frans Pop
2009-10-27 21:00 ` Frans Pop
2009-10-17 18:34 ` [PATCH 0/2] Reduce number of GFP_ATOMIC allocation failures Karol Lewandowski
2009-10-18 22:18 ` Karol Lewandowski
2009-10-18 22:31 ` Frans Pop
2009-10-19 0:36 ` Karol Lewandowski
2009-10-19 14:13 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255689446-3858-3-git-send-email-mel@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=elendil@planet.nl \
--cc=kalle.valo@iki.fi \
--cc=karol.k.lewandowski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=reinette.chatre@intel.com \
--cc=rjw@sisk.pl \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).