Re: [PATCH-RFC] cfq: Disable low_latency by default for 2.6.32

KOSAKI Motohiro
2009-11-27T04:36:25Z

> Signed-off-by: Mel Gorman <mel@csn.ul.ie>
> ---
> block/cfq-iosched.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
> index aa1e953..dc33045 100644
> --- a/block/cfq-iosched.c
> +++ b/block/cfq-iosched.c
> @@ -2543,7 +2543,7 @@ static void *cfq_init_queue(struct request_queue *q)
> cfqd->cfq_slice[1] = cfq_slice_sync;
> cfqd->cfq_slice_async_rq = cfq_slice_async_rq;
> cfqd->cfq_slice_idle = cfq_slice_idle;
> - cfqd->cfq_latency = 1;
> + cfqd->cfq_latency = 0;
> cfqd->hw_tag = 1;
> cfqd->last_end_sync_rq = jiffies;
> return cfqd;

Great. Probably we can reenable this feature at 2.6.33. but there isn't any reason to take
any risk at 2.6.32. i.e. This simple disabling is best. I like this.

Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>