From: Joe Perches <joe@perches.com>
To: Matt Mackall <mpm@selenic.com>
Cc: linux-kernel@vger.kernel.org,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
linux-mm@kvack.org
Subject: Re: [PATCH 09/10] mm/slab.c: Fix continuation line formats
Date: Sun, 31 Jan 2010 12:13:59 -0800 [thread overview]
Message-ID: <1264968839.25140.169.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1264968523.3536.1801.camel@calx>
On Sun, 2010-01-31 at 14:08 -0600, Matt Mackall wrote:
> On Sun, 2010-01-31 at 12:02 -0800, Joe Perches wrote:
> > diff --git a/mm/slab.c b/mm/slab.c
> > index 7451bda..9964619 100644
> > --- a/mm/slab.c
> > +++ b/mm/slab.c
> > @@ -4228,8 +4228,8 @@ static int s_show(struct seq_file *m, void *p)
> > unsigned long node_frees = cachep->node_frees;
> > unsigned long overflows = cachep->node_overflow;
> >
> > - seq_printf(m, " : globalstat %7lu %6lu %5lu %4lu \
> > - %4lu %4lu %4lu %4lu %4lu", allocs, high, grown,
> > + seq_printf(m, " : globalstat %7lu %6lu %5lu %4lu %4lu %4lu %4lu %4lu %4lu",
> > + allocs, high, grown,
>
> Yuck. The right way to do this is by mergeable adjacent strings, eg:
>
> printk("part 1..."
> " part 2...", ...);
Yuck indeed.
I think format strings shouldn't be split across multiple lines and
the right thing to do is to use a single space instead of the tabs.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-31 20:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 20:02 [PATCH 00/10] treewide: Fix format strings that misuse continuations Joe Perches
2010-01-31 20:02 ` [PATCH 09/10] mm/slab.c: Fix continuation line formats Joe Perches
2010-01-31 20:08 ` Matt Mackall
2010-01-31 20:13 ` Joe Perches [this message]
2010-01-31 20:32 ` Frans Pop
2010-01-31 20:38 ` Joe Perches
2010-01-31 23:53 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264968839.25140.169.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).