From: John Kacur <jkacur@redhat.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Minchan Kim <minchan.kim@gmail.com>,
linux-mm@kvack.org, Steven@kvack.org,
"Rostedt <rostedt"@goodmis.org, John Kacur <jkacur@redhat.com>
Subject: [RFC][PATCH] vmscan: balance local_irq_disable() and local_irq_enable()
Date: Wed, 3 Feb 2010 20:53:21 +0100 [thread overview]
Message-ID: <1265226801-6199-2-git-send-email-jkacur@redhat.com> (raw)
In-Reply-To: <1265226801-6199-1-git-send-email-jkacur@redhat.com>
Balance local_irq_disable() and local_irq_enable() as well as
spin_lock_irq() and spin_lock_unlock_irq
Signed-off-by: John Kacur <jkacur@redhat.com>
---
mm/vmscan.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index c26986c..b895025 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1200,8 +1200,9 @@ static unsigned long shrink_inactive_list(unsigned long max_scan,
if (current_is_kswapd())
__count_vm_events(KSWAPD_STEAL, nr_freed);
__count_zone_vm_events(PGSTEAL, zone, nr_freed);
+ local_irq_enable();
- spin_lock(&zone->lru_lock);
+ spin_lock_irq(&zone->lru_lock);
/*
* Put back any unfreeable pages.
*/
--
1.6.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-02-03 19:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 19:53 [RFC][PATCH] vmscan: Unbalanced local_irq_disable and enable John Kacur
2010-02-03 19:53 ` John Kacur [this message]
2010-02-03 20:09 ` [RFC][PATCH] vmscan: balance local_irq_disable() and local_irq_enable() Steven Rostedt
2010-02-03 20:12 ` John Kacur
2010-02-04 0:22 ` KOSAKI Motohiro
2010-02-05 16:05 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265226801-6199-2-git-send-email-jkacur@redhat.com \
--to=jkacur@redhat.com \
--cc="Rostedt <rostedt"@goodmis.org \
--cc=Steven@kvack.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=mingo@elte.hu \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).