From: Huang Shijie <shijie8@gmail.com>
To: akpm@linux-foundation.org
Cc: hugh.dickins@tiscali.co.uk, linux-mm@kvack.org,
Huang Shijie <shijie8@gmail.com>
Subject: [PATCH] shmem : remove redundant code
Date: Mon, 8 Mar 2010 17:33:02 +0800 [thread overview]
Message-ID: <1268040782-28561-1-git-send-email-shijie8@gmail.com> (raw)
The prep_new_page() will call set_page_private(page, 0) to initiate
the page.
So the code is redundant.
Signed-off-by: Huang Shijie <shijie8@gmail.com>
---
mm/shmem.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index eef4ebe..dde4363 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -433,8 +433,6 @@ static swp_entry_t *shmem_swp_alloc(struct shmem_inode_info *info, unsigned long
spin_unlock(&info->lock);
page = shmem_dir_alloc(mapping_gfp_mask(inode->i_mapping));
- if (page)
- set_page_private(page, 0);
spin_lock(&info->lock);
if (!page) {
--
1.6.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2010-03-08 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 9:33 Huang Shijie [this message]
2010-03-08 16:04 ` [PATCH] shmem : remove redundant code Minchan Kim
2010-03-09 2:02 ` Huang Shijie
2010-03-08 16:20 ` [PATCH] kvm : remove redundant initialization of page->private Minchan Kim
2010-03-10 10:19 ` Avi Kivity
2010-03-10 14:31 ` Minchan Kim
2010-03-11 7:42 ` Avi Kivity
2010-03-11 8:51 ` Jan Kiszka
2010-03-11 8:55 ` Avi Kivity
2010-03-11 18:43 ` Hugh Dickins
2010-03-09 21:25 ` [PATCH] shmem : remove redundant code Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268040782-28561-1-git-send-email-shijie8@gmail.com \
--to=shijie8@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).