From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linux-mm@kvack.org
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: mprotect pgprot handling weirdness
Date: Tue, 06 Apr 2010 15:32:06 +1000 [thread overview]
Message-ID: <1270531926.13812.29.camel@pasglop> (raw)
In-Reply-To: <1270530566.13812.28.camel@pasglop>
On Tue, 2010-04-06 at 15:09 +1000, Benjamin Herrenschmidt wrote:
> Hi folks !
>
> While looking at untangling a bit some of the mess with vm_flags and
> pgprot (*), I notices a few things I can't quite explain... they may ..
> or may not be bugs, but I though it was worth mentioning:
And another one:
- vma_wants_writenotify():
/* The open routine did something to the protections already? */
if (pgprot_val(vma->vm_page_prot) !=
pgprot_val(vm_get_page_prot(vm_flags)))
return 0;
That's going to blow if any -other- prot bit is used here.
Cheers,
Ben.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-06 5:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 5:09 mprotect pgprot handling weirdness Benjamin Herrenschmidt
2010-04-06 5:32 ` Benjamin Herrenschmidt [this message]
2010-04-06 5:43 ` Benjamin Herrenschmidt
2010-04-06 5:52 ` KOSAKI Motohiro
2010-04-06 6:07 ` Arch specific mmap attributes (Was: mprotect pgprot handling weirdness) Benjamin Herrenschmidt
2010-04-06 6:24 ` KOSAKI Motohiro
2010-04-06 7:30 ` Benjamin Herrenschmidt
2010-04-06 10:26 ` KOSAKI Motohiro
2010-04-06 22:15 ` Benjamin Herrenschmidt
2010-04-07 6:03 ` KOSAKI Motohiro
2010-04-07 7:03 ` Arch specific mmap attributes David Miller
2010-04-07 7:14 ` KOSAKI Motohiro
2010-04-07 7:18 ` David Miller
2010-04-07 9:00 ` Benjamin Herrenschmidt
2010-04-07 8:58 ` Benjamin Herrenschmidt
2010-04-07 8:56 ` Arch specific mmap attributes (Was: mprotect pgprot handling weirdness) Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270531926.13812.29.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).