From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id CDC306B01E3 for ; Wed, 14 Apr 2010 10:59:18 -0400 (EDT) Received: by wyg36 with SMTP id 36so100737wyg.14 for ; Wed, 14 Apr 2010 07:59:16 -0700 (PDT) From: Minchan Kim Subject: [PATCH v2] Remove node's validity check in alloc_pages Date: Wed, 14 Apr 2010 23:58:34 +0900 Message-Id: <1271257119-30117-1-git-send-email-minchan.kim@gmail.com> Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: Mel Gorman , KAMEZAWA Hiroyuki , Bob Liu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Minchan Kim List-ID: V2 * Add some reviewed-by alloc_pages calls alloc_pages_node with numa_node_id(). alloc_pages_node can't see nid < 0. So we can use alloc_pages_exact_node instead of alloc_pages_node. It could avoid comparison and branch as 6484eb3e2a81807722 tried. Reviewed-by: Mel Gorman Acked-by: KAMEZAWA Hiroyuki Signed-off-by: Minchan Kim --- include/linux/gfp.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/gfp.h b/include/linux/gfp.h index 4c6d413..b65f003 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h @@ -308,7 +308,7 @@ extern struct page *alloc_page_vma(gfp_t gfp_mask, struct vm_area_struct *vma, unsigned long addr); #else #define alloc_pages(gfp_mask, order) \ - alloc_pages_node(numa_node_id(), gfp_mask, order) + alloc_pages_exact_node(numa_node_id(), gfp_mask, order) #define alloc_page_vma(gfp_mask, vma, addr) alloc_pages(gfp_mask, 0) #endif #define alloc_page(gfp_mask) alloc_pages(gfp_mask, 0) -- 1.7.0.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org