From: Gleb Natapov <gleb@redhat.com>
To: kvm@vger.kernel.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, avi@redhat.com,
mingo@elte.hu, a.p.zijlstra@chello.nl, tglx@linutronix.de,
hpa@zytor.com, riel@redhat.com, cl@linux-foundation.org,
mtosatti@redhat.com
Subject: [PATCH v4 11/12] Let host know whether the guest can handle async PF in non-userspace context.
Date: Tue, 6 Jul 2010 19:24:59 +0300 [thread overview]
Message-ID: <1278433500-29884-12-git-send-email-gleb@redhat.com> (raw)
In-Reply-To: <1278433500-29884-1-git-send-email-gleb@redhat.com>
If guest can detect that it runs in non-preemptable context it can
handle async PFs at any time, so let host know that it can send async
PF even if guest cpu is not in userspace.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
arch/x86/include/asm/kvm_host.h | 1 +
arch/x86/include/asm/kvm_para.h | 1 +
arch/x86/kernel/kvm.c | 3 +++
arch/x86/kvm/x86.c | 5 +++--
4 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index 45e6c12..c675d5d 100644
--- a/arch/x86/include/asm/kvm_host.h
+++ b/arch/x86/include/asm/kvm_host.h
@@ -367,6 +367,7 @@ struct kvm_vcpu_arch {
cpumask_var_t wbinvd_dirty_mask;
u32 __user *apf_data;
+ bool apf_send_user_only;
u32 apf_memslot_ver;
u64 apf_msr_val;
u32 async_pf_id;
diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h
index edf07cf..a33372c 100644
--- a/arch/x86/include/asm/kvm_para.h
+++ b/arch/x86/include/asm/kvm_para.h
@@ -38,6 +38,7 @@
#define KVM_MAX_MMU_OP_BATCH 32
#define KVM_ASYNC_PF_ENABLED (1 << 0)
+#define KVM_ASYNC_PF_SEND_ALWAYS (1 << 1)
/* Operations for KVM_HC_MMU_OP */
#define KVM_MMU_OP_WRITE_PTE 1
diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index f4d87b3..f2063c2 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -488,6 +488,9 @@ void __cpuinit kvm_guest_cpu_init(void)
if (kvm_para_has_feature(KVM_FEATURE_ASYNC_PF)) {
u64 pa = __pa(&__get_cpu_var(apf_reason));
+#ifdef CONFIG_PREEMPT
+ pa |= KVM_ASYNC_PF_SEND_ALWAYS;
+#endif
if (native_write_msr_safe(MSR_KVM_ASYNC_PF_EN,
pa | KVM_ASYNC_PF_ENABLED, pa >> 32))
return;
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index ae7164e..8f2ff7b 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1220,8 +1220,8 @@ static int kvm_pv_enable_async_pf(struct kvm_vcpu *vcpu, u64 data)
int offset = offset_in_page(gpa);
unsigned long addr;
- /* Bits 1:5 are resrved, Should be zero */
- if (data & 0x3e)
+ /* Bits 2:5 are resrved, Should be zero */
+ if (data & 0x3c)
return 1;
vcpu->arch.apf_msr_val = data;
@@ -1244,6 +1244,7 @@ static int kvm_pv_enable_async_pf(struct kvm_vcpu *vcpu, u64 data)
return 1;
}
vcpu->arch.apf_memslot_ver = vcpu->kvm->memslot_version;
+ vcpu->arch.apf_send_user_only = !(data & KVM_ASYNC_PF_SEND_ALWAYS);
kvm_async_pf_wakeup_all(vcpu);
return 0;
}
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-07-06 16:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 16:24 [PATCH v4 00/12] KVM: Add host swap event notifications for PV guest Gleb Natapov
2010-07-06 16:24 ` [PATCH v4 01/12] Move kvm_smp_prepare_boot_cpu() from kvmclock.c to kvm.c Gleb Natapov
2010-07-07 16:17 ` Rik van Riel
2010-07-06 16:24 ` [PATCH v4 02/12] Add PV MSR to enable asynchronous page faults delivery Gleb Natapov
2010-07-07 18:13 ` Rik van Riel
2010-07-06 16:24 ` [PATCH v4 03/12] Add async PF initialization to PV guest Gleb Natapov
2010-07-07 15:41 ` Peter Zijlstra
2010-07-08 13:24 ` Gleb Natapov
2010-07-06 16:24 ` [PATCH v4 04/12] Provide special async page fault handler when async PF capability is detected Gleb Natapov
2010-07-07 22:38 ` Rik van Riel
2010-07-06 16:24 ` [PATCH v4 05/12] Export __get_user_pages_fast Gleb Natapov
2010-07-07 22:45 ` Rik van Riel
2010-07-06 16:24 ` [PATCH v4 06/12] Add get_user_pages() variant that fails if major fault is required Gleb Natapov
2010-07-06 16:24 ` [PATCH v4 07/12] Maintain memslot version number Gleb Natapov
2010-07-08 0:19 ` Rik van Riel
2010-07-06 16:24 ` [PATCH v4 08/12] Inject asynchronous page fault into a guest if page is swapped out Gleb Natapov
2010-07-08 4:09 ` Rik van Riel
2010-07-08 15:59 ` Marcelo Tosatti
2010-07-08 18:05 ` Gleb Natapov
2010-07-08 18:09 ` Peter Zijlstra
2010-07-08 18:10 ` Peter Zijlstra
2010-07-09 15:50 ` Gleb Natapov
2010-07-06 16:24 ` [PATCH v4 09/12] Retry fault before vmentry Gleb Natapov
2010-07-08 4:21 ` Rik van Riel
2010-07-08 16:17 ` Marcelo Tosatti
2010-07-06 16:24 ` [PATCH v4 10/12] Handle async PF in non preemptable context Gleb Natapov
2010-07-08 4:22 ` Rik van Riel
2010-07-06 16:24 ` Gleb Natapov [this message]
2010-07-08 4:28 ` [PATCH v4 11/12] Let host know whether the guest can handle async PF in non-userspace context Rik van Riel
2010-07-08 13:35 ` Gleb Natapov
2010-07-06 16:25 ` [PATCH v4 12/12] Send async PF when guest is not in userspace too Gleb Natapov
2010-07-08 4:29 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278433500-29884-12-git-send-email-gleb@redhat.com \
--to=gleb@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=avi@redhat.com \
--cc=cl@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).