From: Steven Rostedt <rostedt@goodmis.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Nishimura Daisuke <d-nishimura@mtf.biglobe.ne.jp>
Subject: Re: [PATCH 4/7] vmscan: convert direct reclaim tracepoint to DEFINE_EVENT
Date: Tue, 20 Jul 2010 18:45:08 -0400 [thread overview]
Message-ID: <1279665908.4818.7.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20100716110859.GH13117@csn.ul.ie>
On Fri, 2010-07-16 at 12:08 +0100, Mel Gorman wrote:
>
> > +DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_direct_reclaim_end,
> > +
> > + TP_PROTO(unsigned long nr_reclaimed),
> > +
> > + TP_ARGS(nr_reclaimed)
> > +);
> > +
>
> Over 80 columns here too.
>
> I know I broke it multiple times in my last series because I thought it
> wasn't enforced any more but I got called on it.
Note, The TRACE_EVENT() macros have a bit more leniency to the 80 column
rule.
-- Steve
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-07-20 22:45 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 10:12 [PATCH 0/7] memcg reclaim tracepoint KOSAKI Motohiro
2010-07-16 10:13 ` [PATCH 1/7] memcg: sc.nr_to_reclaim should be initialized KOSAKI Motohiro
2010-07-16 10:17 ` KAMEZAWA Hiroyuki
2010-07-16 10:25 ` Mel Gorman
2010-07-21 13:34 ` KOSAKI Motohiro
2010-07-22 5:31 ` Balbir Singh
2010-07-23 7:33 ` KOSAKI Motohiro
2010-07-25 8:25 ` Balbir Singh
2010-07-25 9:48 ` KOSAKI Motohiro
2010-07-25 16:40 ` Balbir Singh
2010-07-16 10:14 ` [PATCH 2/7] memcg: mem_cgroup_shrink_node_zone() doesn't need sc.nodemask KOSAKI Motohiro
2010-07-16 10:18 ` KAMEZAWA Hiroyuki
2010-07-16 10:47 ` Mel Gorman
2010-07-22 4:49 ` Balbir Singh
2010-07-23 5:14 ` KOSAKI Motohiro
2010-07-25 8:28 ` Balbir Singh
2010-07-16 10:15 ` [PATCH 3/7] memcg: nid and zid can be calculated from zone KOSAKI Motohiro
2010-07-16 10:19 ` KAMEZAWA Hiroyuki
2010-07-16 10:56 ` Mel Gorman
2010-07-21 13:33 ` KOSAKI Motohiro
2010-07-22 5:36 ` Balbir Singh
2010-07-22 11:01 ` Mel Gorman
2010-07-16 10:16 ` [PATCH 4/7] vmscan: convert direct reclaim tracepoint to DEFINE_EVENT KOSAKI Motohiro
2010-07-16 10:20 ` KAMEZAWA Hiroyuki
2010-07-16 11:08 ` Mel Gorman
2010-07-20 22:45 ` Steven Rostedt [this message]
2010-07-16 10:16 ` [PATCH 5/7] memcg, vmscan: add memcg reclaim tracepoint KOSAKI Motohiro
2010-07-16 10:21 ` KAMEZAWA Hiroyuki
2010-07-16 11:17 ` Mel Gorman
2010-07-22 5:34 ` Balbir Singh
2010-07-16 10:17 ` [PATCH 6/7] vmscan: convert mm_vmscan_lru_isolate to DEFINE_EVENT KOSAKI Motohiro
2010-07-16 10:22 ` KAMEZAWA Hiroyuki
2010-07-16 10:18 ` [PATCH 7/7] memcg: add mm_vmscan_memcg_isolate tracepoint KOSAKI Motohiro
2010-07-16 10:23 ` KAMEZAWA Hiroyuki
2010-07-16 11:21 ` Mel Gorman
2010-07-16 13:18 ` Mel Gorman
2010-07-20 1:47 ` [PATCH 0/7] memcg reclaim tracepoint Daisuke Nishimura
2010-07-22 4:00 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279665908.4818.7.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=d-nishimura@mtf.biglobe.ne.jp \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).