From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id BDAF76B024D for ; Wed, 21 Jul 2010 14:18:01 -0400 (EDT) Subject: Re: [PATCH 2/4] mm: cma: Contiguous Memory Allocator added From: Daniel Walker In-Reply-To: References: <1279649724.26765.23.camel@c-dwalke-linux.qualcomm.com> <1279654698.26765.31.camel@c-dwalke-linux.qualcomm.com> <1279733750.31376.14.camel@c-dwalke-linux.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 21 Jul 2010 11:19:08 -0700 Message-ID: <1279736348.31376.20.camel@c-dwalke-linux.qualcomm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org To: =?UTF-8?Q?Micha=C5=82?= Nazarewicz Cc: linux-mm@kvack.org, Marek Szyprowski , Pawel Osciak , Xiaolin Zhang , Hiremath Vaibhav , Robert Fekete , Marcus Lorentzon , linux-kernel@vger.kernel.org, Kyungmin Park , linux-arm-msm@vger.kernel.org List-ID: On Wed, 2010-07-21 at 20:11 +0200, MichaA? Nazarewicz wrote: > >> > (btw, these strings your creating yikes, talk about confusing ..) > >> > >> They are not that scary really. Let's look at cma: > >> > >> a=10M;b=10M > >> > >> Split it on semicolon: > >> > >> a=10M > >> b=10M > >> > >> and you see that it defines two regions (a and b) 10M each. > > > > I think your assuming a lot .. I've never seen the notation before I > > wouldn't assuming there's regions or whatever .. > > That's why there is documentation with grammar included. :) > > >> As of cma_map: > >> > >> camera,video=a;jpeg,scaler=b > >> > >> Again split it on semicolon: > >> > >> camera,video=a > >> jpeg,scaler=b > >> > >> Now, substitute equal sign by "use(s) region(s)": > >> > >> camera,video use(s) region(s): a > >> jpeg,scaler use(s) region(s): b > >> > >> No black magic here. ;) > > > > It way too complicated .. Users (i.e. not programmers) has to use > > this .. > > Not really. This will probably be used mostly on embedded systems > where users don't have much to say as far as hardware included on the > platform is concerned, etc. Once a phone, tablet, etc. is released > users will have little need for customising those strings. You can't assume that user won't want to reflash their own kernel on the device. Your assuming way too much. If you assume they do want their own kernel then they would need this string from someplace. If your right and this wouldn't need to change, why bother allowing it to be configured at all ? Daniel -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org